From: Bastien Nocera <hadess@hadess.net>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, Stephen Just <stephenjust@gmail.com>,
patches.audio@intel.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
liam.r.girdwood@linux.intel.com, apterix@gmail.com,
broonie@kernel.org, Sachin Mokashi <sachinx.mokashi@intel.com>,
bugzilla@hadess.net
Subject: Re: [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine
Date: Wed, 20 Jul 2016 13:27:12 +0200 [thread overview]
Message-ID: <1469014032.6761.43.camel@hadess.net> (raw)
In-Reply-To: <20160720035834.GH9681@localhost>
On Wed, 2016-07-20 at 09:28 +0530, Vinod Koul wrote:
> On Tue, Jul 19, 2016 at 04:56:24PM +0200, Bastien Nocera wrote:
> > > + /* fixup codec name based on HID */
> > > + i2c_name = sst_acpi_find_name_from_hid(mach->id);
> > > + if (i2c_name != NULL) {
> > > + snprintf(cht_rt5640_codec_name,
> > > sizeof(cht_rt5640_codec_name),
> > > + "%s%s", "i2c-", i2c_name);
> > > + cht_dailink[dai_index].codec_name =
> > > cht_rt5640_codec_name;
> >
> > FWIW, I get:
> > sound/soc/intel/boards/cht_bsw_rt5645.c: In function
> > 'snd_cht_mc_probe':
> > sound/soc/intel/boards/cht_bsw_rt5645.c:391:37: warning:
> > 'dai_index' may be used uninitialized in this function [-Wmaybe-
> > uninitialized]
> > cht_dailink[dai_index].codec_name = cht_rt5640_codec_name;
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
>
> Yeah I notice them a bit later. The fixes are already in mark's-next.
Care to be a bit more specific. Kind of hard to know which Mark you're
talking about when there's no one of that name in the CC: list above.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-07-20 11:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 10:09 [PATCH 0/3] ASoC: Intel: Add support for surface3 tablet Vinod Koul
2016-07-08 10:09 ` [PATCH 1/3] ASoC: Intel: Atom: Add quirk for Surface 3 Vinod Koul
2016-07-08 12:32 ` Applied "ASoC: Intel: Atom: Add quirk for Surface 3" to the asoc tree Mark Brown
2016-07-08 10:09 ` [PATCH 2/3] ASoC: rt5645: Add ACPI ID 10EC5640 Vinod Koul
2016-07-08 10:09 ` [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine Vinod Koul
2016-07-08 12:32 ` Applied "ASoC: Intel: Add surface3 entry in CHT-RT5645 machine" to the asoc tree Mark Brown
2016-07-19 14:56 ` [PATCH 3/3] ASoC: Intel: Add surface3 entry in CHT-RT5645 machine Bastien Nocera
2016-07-20 3:58 ` Vinod Koul
2016-07-20 11:27 ` Bastien Nocera [this message]
2016-07-20 11:33 ` Mokashi, SachinX
2016-07-20 11:51 ` Bastien Nocera
2016-07-20 14:47 ` [PATCH 0/3] ASoC: Intel: Add support for surface3 tablet Bastien Nocera
2016-07-20 15:05 ` Stephen J
2016-07-20 16:12 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469014032.6761.43.camel@hadess.net \
--to=hadess@hadess.net \
--cc=alsa-devel@alsa-project.org \
--cc=apterix@gmail.com \
--cc=broonie@kernel.org \
--cc=bugzilla@hadess.net \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sachinx.mokashi@intel.com \
--cc=stephenjust@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox