From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v8 1/5] video: rmk's HDMI notification prototype Date: Thu, 11 Aug 2016 16:40:46 +0200 Message-ID: <1470926446.2493.48.camel@pengutronix.de> References: <1470907227-899-1-git-send-email-p.zabel@pengutronix.de> <1470907227-899-2-git-send-email-p.zabel@pengutronix.de> <20160811101817.GT1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160811101817.GT1041-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Russell King - ARM Linux Cc: Jean-Francois Moine , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Lars-Peter Clausen , Arnaud Pouliquen , Koro Chen , Jyri Sarha , Liam Girdwood , Mark Brown , Hans Verkuil , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, PC Liao , Matthias Brugger , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Cawa Cheng List-Id: alsa-devel@alsa-project.org Am Donnerstag, den 11.08.2016, 11:18 +0100 schrieb Russell King - ARM Linux: > On Thu, Aug 11, 2016 at 11:20:23AM +0200, Philipp Zabel wrote: > > This is Russell's HDMI notification prototype [1], currently waiting > > for the HDMI CEC situation to resolve. > > > > The use case for the notifications on MediaTek MT8173 is to let the > > (dis)connection notifications control an ALSA jack object. > > > > No Signed-off-by since this is not my code, and still up for discussion. > > Well, I have two drivers (both CEC drivers) which use this, and I still > don't see any alternative solution to the problem that this patch is > solving. > > I don't think it's really a CEC problem - there's three bits to HDMI > that need to track each others state - the video, audio and CEC paths. > > While the video and audio paths may be one block, the CEC path may > actually be a separate block. For example, the TDA998x devices > integrate the HDMI video/audio block along with a TDA9950 on the > same device - the TDA9950 being a CEC engine. The TDA9950 is also > available as a separate device, and even when integrated with HDMI, > it appears on the I2C bus as a seperate device. > > So, splitting the functionality is definitely the right model. We > just need some way to keep each blocks state in sync. What's provided > in this patch is the simple solution which seems to work for the use > cases we have. Yes, it works fine for the MT8173 use case. > I think, in light of no comments against this approach, and no other > approach being available, that this is good enough justification to > merge this, especially as it is blocking other work. > > So... if people want to give me reviewed-by/acked-bys, I'll add them > to my patch, and I'll post that and the dw-hdmi and tda9950 CEC drivers. Acked-by: Philipp Zabel regards Philipp