* [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
@ 2016-08-12 18:08 Akshay Bhat
2016-08-29 14:10 ` Akshay Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Bhat @ 2016-08-12 18:08 UTC (permalink / raw)
To: perex
Cc: tiwai, gtmkramer, denk, guillaume, vdronov, alsa-devel,
linux-kernel, Ken Lin, Akshay Bhat
From: Ken Lin <ken.lin@advantech.com.tw>
Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
causes noisy "current rate is different from the runtime rate" messages
when playback starts.
Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
---
sound/usb/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 6adde45..e5a1133 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1139,6 +1139,7 @@ bool snd_usb_get_sample_rate_quirk(struct snd_usb_audio *chip)
case USB_ID(0x04D8, 0xFEEA): /* Benchmark DAC1 Pre */
case USB_ID(0x0556, 0x0014): /* Phoenix Audio TMX320VC */
case USB_ID(0x074D, 0x3553): /* Outlaw RR2150 (Micronas UAC3553B) */
+ case USB_ID(0x1901, 0x0191): /* GE B850V3 CP2114 audio interface */
case USB_ID(0x1de7, 0x0013): /* Phoenix Audio MT202exe */
case USB_ID(0x1de7, 0x0014): /* Phoenix Audio TMX320 */
case USB_ID(0x1de7, 0x0114): /* Phoenix Audio MT202pcs */
--
2.8.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-12 18:08 [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114 Akshay Bhat
@ 2016-08-29 14:10 ` Akshay Bhat
2016-08-29 14:13 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Bhat @ 2016-08-29 14:10 UTC (permalink / raw)
To: perex
Cc: tiwai, gtmkramer, denk, guillaume, vdronov, alsa-devel,
linux-kernel, Ken Lin, Akshay Bhat
Hi,
On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> From: Ken Lin <ken.lin@advantech.com.tw>
>
> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> causes noisy "current rate is different from the runtime rate" messages
> when playback starts.
>
> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> ---
Any feedback on the patch? If not can it be applied? Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-29 14:10 ` Akshay Bhat
@ 2016-08-29 14:13 ` Takashi Iwai
2016-08-29 14:45 ` Akshay Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2016-08-29 14:13 UTC (permalink / raw)
To: Akshay Bhat
Cc: perex, Ken Lin, alsa-devel, guillaume, denk, vdronov,
linux-kernel, gtmkramer
On Mon, 29 Aug 2016 16:10:03 +0200,
Akshay Bhat wrote:
>
> Hi,
>
> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> > From: Ken Lin <ken.lin@advantech.com.tw>
> >
> > Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> > causes noisy "current rate is different from the runtime rate" messages
> > when playback starts.
> >
> > Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> > Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> > ---
>
> Any feedback on the patch? If not can it be applied? Thanks.
It's already included in 4.8-rc4. I thought I replied it, but it
seems to be forgotten, as this was received during my vacation,
sorry.
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-29 14:13 ` Takashi Iwai
@ 2016-08-29 14:45 ` Akshay Bhat
2016-08-29 14:49 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Bhat @ 2016-08-29 14:45 UTC (permalink / raw)
To: Takashi Iwai
Cc: perex, Ken Lin, alsa-devel, guillaume, denk, vdronov,
linux-kernel, gtmkramer
On 08/29/2016 10:13 AM, Takashi Iwai wrote:
> On Mon, 29 Aug 2016 16:10:03 +0200,
> Akshay Bhat wrote:
>>
>> Hi,
>>
>> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
>>> From: Ken Lin <ken.lin@advantech.com.tw>
>>>
>>> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
>>> causes noisy "current rate is different from the runtime rate" messages
>>> when playback starts.
>>>
>>> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
>>> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
>>> ---
>>
>> Any feedback on the patch? If not can it be applied? Thanks.
>
> It's already included in 4.8-rc4. I thought I replied it, but it
> seems to be forgotten, as this was received during my vacation,
> sorry.
>
>
> Takashi
>
Thank you Takashi. I don't see it as part of 4.8-rc4 yet (unless I am
looking at the wrong tree).
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/usb/quirks.c?id=refs/tags/v4.8-rc4#n1127
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-29 14:45 ` Akshay Bhat
@ 2016-08-29 14:49 ` Takashi Iwai
2016-08-30 15:06 ` Akshay Bhat
0 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2016-08-29 14:49 UTC (permalink / raw)
To: Akshay Bhat
Cc: perex, Ken Lin, alsa-devel, guillaume, denk, vdronov,
linux-kernel, gtmkramer
On Mon, 29 Aug 2016 16:45:58 +0200,
Akshay Bhat wrote:
>
>
>
> On 08/29/2016 10:13 AM, Takashi Iwai wrote:
> > On Mon, 29 Aug 2016 16:10:03 +0200,
> > Akshay Bhat wrote:
> >>
> >> Hi,
> >>
> >> On Fri, Aug 12, 2016 at 2:08 PM, Akshay Bhat <akshay.bhat@timesys.com> wrote:
> >>> From: Ken Lin <ken.lin@advantech.com.tw>
> >>>
> >>> Avoid getting sample rate on B850V3 CP2114 as it is unsupported and
> >>> causes noisy "current rate is different from the runtime rate" messages
> >>> when playback starts.
> >>>
> >>> Signed-off-by: Ken Lin <ken.lin@advantech.com.tw>
> >>> Signed-off-by: Akshay Bhat <akshay.bhat@timesys.com>
> >>> ---
> >>
> >> Any feedback on the patch? If not can it be applied? Thanks.
> >
> > It's already included in 4.8-rc4. I thought I replied it, but it
> > seems to be forgotten, as this was received during my vacation,
> > sorry.
> >
> >
> > Takashi
> >
>
> Thank you Takashi. I don't see it as part of 4.8-rc4 yet (unless I am
> looking at the wrong tree).
>
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/usb/quirks.c?id=refs/tags/v4.8-rc4#n1127
Gah, then it was a different one. Obviously I overlooked your patch
during my vacation. Will put it to the queue.
But, this message should appear only once in the recent version. Does
it still annoy as appearing repeatedly at all...?
thanks,
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-29 14:49 ` Takashi Iwai
@ 2016-08-30 15:06 ` Akshay Bhat
2016-08-30 15:10 ` Takashi Iwai
0 siblings, 1 reply; 7+ messages in thread
From: Akshay Bhat @ 2016-08-30 15:06 UTC (permalink / raw)
To: Takashi Iwai
Cc: perex, Ken Lin, alsa-devel, guillaume, denk, vdronov,
linux-kernel, gtmkramer
On 08/29/2016 10:49 AM, Takashi Iwai wrote:
>
> Gah, then it was a different one. Obviously I overlooked your patch
> during my vacation. Will put it to the queue.
>
> But, this message should appear only once in the recent version. Does
> it still annoy as appearing repeatedly at all...?
>
Hi Takashi,
Thanks for adding it in the queue. You are correct, I believe when we
last tested it on 4.7 the message appeared once per playback, so the
commit message might be a bit misleading.
Thanks,
Akshay
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114
2016-08-30 15:06 ` Akshay Bhat
@ 2016-08-30 15:10 ` Takashi Iwai
0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2016-08-30 15:10 UTC (permalink / raw)
To: Akshay Bhat
Cc: perex, Ken Lin, alsa-devel, guillaume, denk, vdronov,
linux-kernel, gtmkramer
On Tue, 30 Aug 2016 17:06:13 +0200,
Akshay Bhat wrote:
>
>
>
> On 08/29/2016 10:49 AM, Takashi Iwai wrote:
> >
> > Gah, then it was a different one. Obviously I overlooked your patch
> > during my vacation. Will put it to the queue.
> >
> > But, this message should appear only once in the recent version. Does
> > it still annoy as appearing repeatedly at all...?
> >
>
> Hi Takashi,
>
> Thanks for adding it in the queue. You are correct, I believe when we
> last tested it on 4.7 the message appeared once per playback, so the
> commit message might be a bit misleading.
Don't mind, as this is a stable patch and it's indeed appearing
repeatedly in older kernels to be backported.
Takashi
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-30 15:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-12 18:08 [PATCH] ALSA: usb-audio: Add sample rate inquiry quirk for B850V3 CP2114 Akshay Bhat
2016-08-29 14:10 ` Akshay Bhat
2016-08-29 14:13 ` Takashi Iwai
2016-08-29 14:45 ` Akshay Bhat
2016-08-29 14:49 ` Takashi Iwai
2016-08-30 15:06 ` Akshay Bhat
2016-08-30 15:10 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).