From: Andrej Krutak <dev@andree.sk>
To: tiwai@suse.com, perex@perex.cz, stefanha@gmail.com,
grabner@icg.tugraz.at, alsa-devel@alsa-project.org
Cc: Andrej Krutak <dev@andree.sk>
Subject: [PATCH 1/3] ALSA: line6: Remove double line6_pcm_release() after failed acquire.
Date: Thu, 18 Aug 2016 23:52:10 +0200 [thread overview]
Message-ID: <1471557132-10206-2-git-send-email-dev@andree.sk> (raw)
In-Reply-To: <1471557132-10206-1-git-send-email-dev@andree.sk>
If there's an error, pcm is released in line6_pcm_acquire already.
Signed-off-by: Andrej Krutak <dev@andree.sk>
---
sound/usb/line6/pcm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c
index 204cc07..2bc8879 100644
--- a/sound/usb/line6/pcm.c
+++ b/sound/usb/line6/pcm.c
@@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol,
err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE);
if (err < 0) {
line6pcm->impulse_volume = 0;
- line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE);
return err;
}
} else {
--
1.9.1
next prev parent reply other threads:[~2016-08-18 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 21:52 [PATCH 0/3] line6 locking and segfault fixes Andrej Krutak
2016-08-18 21:52 ` Andrej Krutak [this message]
2016-08-19 5:54 ` [PATCH 1/3] ALSA: line6: Remove double line6_pcm_release() after failed acquire Stefan Hajnoczi
2016-08-18 21:52 ` [PATCH 2/3] ALSA: line6: Give up on the lock while URBs are released Andrej Krutak
2016-08-18 21:52 ` [PATCH 3/3] ALSA: line6: Fix POD sysfs attributes segfault Andrej Krutak
2016-08-19 5:54 ` Stefan Hajnoczi
2016-08-22 12:03 ` [PATCH 0/3] line6 locking and segfault fixes Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471557132-10206-2-git-send-email-dev@andree.sk \
--to=dev@andree.sk \
--cc=alsa-devel@alsa-project.org \
--cc=grabner@icg.tugraz.at \
--cc=perex@perex.cz \
--cc=stefanha@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).