* [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream
@ 2016-08-26 12:15 Harsha Priya
2016-08-30 15:53 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Harsha Priya @ 2016-08-26 12:15 UTC (permalink / raw)
To: alsa-devel; +Cc: Harsha Priya, Naveen M
If a stream is being dropped, the period_elapsed received then after
need not be processed. Processing of the period_elapsed message causes
a time out in drop stream response processing. This patch adds a condition
to skip period_elapsed message processing if the stream is in INIT state.
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
Signed-off-by: Naveen M <naveen.m@intel.com>
---
sound/soc/intel/atom/sst/sst_ipc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c
index 8afa6fe..bfc8899 100644
--- a/sound/soc/intel/atom/sst/sst_ipc.c
+++ b/sound/soc/intel/atom/sst/sst_ipc.c
@@ -267,6 +267,9 @@ static void process_fw_async_msg(struct intel_sst_drv *sst_drv_ctx,
"Period elapsed rcvd for pipe id 0x%x\n",
pipe_id);
stream = &sst_drv_ctx->streams[str_id];
+ /* If stream is dropped, skip processing this message*/
+ if (stream->status == STREAM_INIT)
+ break;
if (stream->period_elapsed)
stream->period_elapsed(stream->pcm_substream);
if (stream->compr_cb)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream
2016-08-26 12:15 [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream Harsha Priya
@ 2016-08-30 15:53 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2016-08-30 15:53 UTC (permalink / raw)
To: Harsha Priya; +Cc: Naveen M, alsa-devel
On Fri, Aug 26, 2016 at 05:15:17AM -0700, Harsha Priya wrote:
> If a stream is being dropped, the period_elapsed received then after
> need not be processed. Processing of the period_elapsed message causes
> a time out in drop stream response processing. This patch adds a condition
> to skip period_elapsed message processing if the stream is in INIT state.
Acked-by: Vinod Koul <vinod.koul@intel.com>
Harsha,
Pls CC mainatiners, in this case CC Mark & Liam. They may not see this, so I
suggest reporting.
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream
@ 2016-08-31 6:13 Harsha Priya
2016-08-31 10:19 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Harsha Priya @ 2016-08-31 6:13 UTC (permalink / raw)
To: alsa-devel, vinod.koul, lgirdwood, broonie; +Cc: Harsha Priya, Naveen M
If a stream is being dropped, the period_elapsed received then after
need not be processed. Processing of the period_elapsed message causes
a time out in drop stream response processing. This patch adds a condition
to skip period_elapsed message processing if the stream is in INIT state.
Signed-off-by: Harsha Priya <harshapriya.n@intel.com>
Signed-off-by: Naveen M <naveen.m@intel.com>
---
sound/soc/intel/atom/sst/sst_ipc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c
index 8afa6fe..bfc8899 100644
--- a/sound/soc/intel/atom/sst/sst_ipc.c
+++ b/sound/soc/intel/atom/sst/sst_ipc.c
@@ -267,6 +267,9 @@ static void process_fw_async_msg(struct intel_sst_drv *sst_drv_ctx,
"Period elapsed rcvd for pipe id 0x%x\n",
pipe_id);
stream = &sst_drv_ctx->streams[str_id];
+ /* If stream is dropped, skip processing this message*/
+ if (stream->status == STREAM_INIT)
+ break;
if (stream->period_elapsed)
stream->period_elapsed(stream->pcm_substream);
if (stream->compr_cb)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream
2016-08-31 6:13 Harsha Priya
@ 2016-08-31 10:19 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2016-08-31 10:19 UTC (permalink / raw)
To: Harsha Priya; +Cc: Naveen M, alsa-devel, broonie, lgirdwood
On Tue, Aug 30, 2016 at 11:13:05PM -0700, Harsha Priya wrote:
> If a stream is being dropped, the period_elapsed received then after
> need not be processed. Processing of the period_elapsed message causes
> a time out in drop stream response processing. This patch adds a condition
> to skip period_elapsed message processing if the stream is in INIT state.
Acked-by: Vinod Koul <vinod.koul@intel.com>
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-31 10:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 12:15 [PATCH] ASoC: Intel: Atom: Fix message handling during drop stream Harsha Priya
2016-08-30 15:53 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2016-08-31 6:13 Harsha Priya
2016-08-31 10:19 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).