From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap" Date: Wed, 26 Oct 2016 14:28:59 +0200 Message-ID: <1477484939.4059.35.camel@sipsolutions.net> References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54A9355F.4050102@users.sourceforge.net> <54A941C1.4020906@users.sourceforge.net> <20161026122605.GA3911@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161026122605.GA3911@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Dan Carpenter , SF Markus Elfring Cc: alsa-devel@alsa-project.org, Russell King , linux-parisc@vger.kernel.org, Takashi Iwai , kernel-janitors@vger.kernel.org, Clemens Ladisch , LKML , Jaroslav Kysela , Julia Lawall , Thibaut Varene , linuxppc-dev@lists.ozlabs.org List-Id: alsa-devel@alsa-project.org On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote: > Someone was just mentioning in another thread that removing the check > from iounmap() is not portable to other arches and then I remembered > that Markus removed a bunch of these. > > We should consider reverting this, perhaps? Can't we teach all architectures? Not that reverting it would be a problem. johannes