alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>,
	Jayachandran B <jayachandran.b@intel.com>
Subject: [PATCH v2 9/9] ASoC: Intel: Skylake: remove pci device enabling calls on suspend
Date: Thu,  3 Nov 2016 17:07:22 +0530	[thread overview]
Message-ID: <1478173042-9458-10-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1478173042-9458-1-git-send-email-vinod.koul@intel.com>

From: Jayachandran B <jayachandran.b@intel.com>

We were invoking pci_disable_device() while going to suspend-to-idle and
pci_enable_device() while coming back to active state.

Turns out that we do not need these calls as we only need system to be
wake capable when in suspend-to-idle state. The wake capability is
already done by enable_irq_wake() calls, so remove these unwanted calls
in driver.

Signed-off-by: Jayachandran B <jayachandran.b@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
index e544d635de25..da5db5098274 100644
--- a/sound/soc/intel/skylake/skl.c
+++ b/sound/soc/intel/skylake/skl.c
@@ -299,7 +299,6 @@ static int skl_suspend(struct device *dev)
 
 		enable_irq_wake(bus->irq);
 		pci_save_state(pci);
-		pci_disable_device(pci);
 	} else {
 		ret = _skl_suspend(ebus);
 		if (ret < 0)
@@ -342,7 +341,6 @@ static int skl_resume(struct device *dev)
 	 */
 	if (skl->supend_active) {
 		pci_restore_state(pci);
-		ret = pci_enable_device(pci);
 		snd_hdac_ext_bus_link_power_up_all(ebus);
 		disable_irq_wake(bus->irq);
 		/*
-- 
1.9.1

      parent reply	other threads:[~2016-11-03 11:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-03 11:37 [PATCH v2 0/9] ASoC: Intel: Skylake: Add support for D0i3 Vinod Koul
2016-11-03 11:37 ` [PATCH v2 1/9] ASoC: Intel: Add sst_ipc_tx_message_nopm Vinod Koul
2016-11-03 11:37 ` [PATCH v2 2/9] ASoC: Intel: Skylake: Add D0iX IPCs Vinod Koul
2016-11-03 11:37 ` [PATCH v2 3/9] ASoC: Intel: Skylake: Add support for programming D0i3C Vinod Koul
2016-11-03 11:37 ` [PATCH v2 4/9] ASoC: Intel: Skylake: Add D0iX callbacks Vinod Koul
2016-11-03 11:37 ` [PATCH v2 5/9] ASoC: Intel: Skylake: Add support for LPMode Vinod Koul
2016-11-03 11:37 ` [PATCH v2 6/9] ASoC: Intel: Skylake: Add support for specifying D0i3 configuration Vinod Koul
2016-11-03 11:37 ` [PATCH v2 7/9] ASoC: Intel: Skylake: Add D0i3 mode ref counting Vinod Koul
2016-11-03 11:37 ` [PATCH v2 8/9] ASoC: Intel: Skylake: Flush pending D0i3 request on suspend Vinod Koul
2016-11-03 11:37 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478173042-9458-10-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jayachandran.b@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).