* [PATCH] alsa-lib: alsa dshare endless playback of buffer
@ 2016-11-25 11:13 sutar.mounesh
2016-11-28 19:17 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: sutar.mounesh @ 2016-11-25 11:13 UTC (permalink / raw)
To: patch; +Cc: alsa-devel, Anant Agrawal, mounesh_sutar
From: Anant Agrawal <Anant_Agrawal@mentor.com>
On snd_pcm_drain() the slave PCM driven via plugin DSHARE is not filled with
silence. Result is endless playback of buffer content until pcm is closed.
In ALSA pcm dshare plugin, called do_silence method to fix the issue.
Signed-off-by: Anant Agrawal <Anant_Agrawal@mentor.com>
---
--- alsa-lib-1.0.29.orig/src/pcm/pcm_dshare.c 2015-04-28 08:20:44.662995477 -0700
+++ alsa-lib-1.0.29/src/pcm/pcm_dshare.c 2015-04-28 08:20:59.603077419 -0700
@@ -195,6 +195,7 @@
dshare->avail_max = avail;
if (avail >= pcm->stop_threshold) {
snd_timer_stop(dshare->timer);
+ do_silence(pcm);
gettimestamp(&dshare->trigger_tstamp, pcm->tstamp_type);
if (dshare->state == SND_PCM_STATE_RUNNING) {
dshare->state = SND_PCM_STATE_XRUN;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] alsa-lib: alsa dshare endless playback of buffer
2016-11-25 11:13 [PATCH] alsa-lib: alsa dshare endless playback of buffer sutar.mounesh
@ 2016-11-28 19:17 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-11-28 19:17 UTC (permalink / raw)
To: sutar.mounesh; +Cc: alsa-devel, Anant Agrawal, mounesh_sutar
On Fri, 25 Nov 2016 12:13:34 +0100,
sutar.mounesh@gmail.com wrote:
>
> From: Anant Agrawal <Anant_Agrawal@mentor.com>
>
> On snd_pcm_drain() the slave PCM driven via plugin DSHARE is not filled with
> silence. Result is endless playback of buffer content until pcm is closed.
> In ALSA pcm dshare plugin, called do_silence method to fix the issue.
>
> Signed-off-by: Anant Agrawal <Anant_Agrawal@mentor.com>
Applied, thanks.
Takashi
>
> ---
> --- alsa-lib-1.0.29.orig/src/pcm/pcm_dshare.c 2015-04-28 08:20:44.662995477 -0700
> +++ alsa-lib-1.0.29/src/pcm/pcm_dshare.c 2015-04-28 08:20:59.603077419 -0700
> @@ -195,6 +195,7 @@
> dshare->avail_max = avail;
> if (avail >= pcm->stop_threshold) {
> snd_timer_stop(dshare->timer);
> + do_silence(pcm);
> gettimestamp(&dshare->trigger_tstamp, pcm->tstamp_type);
> if (dshare->state == SND_PCM_STATE_RUNNING) {
> dshare->state = SND_PCM_STATE_XRUN;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-28 19:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-25 11:13 [PATCH] alsa-lib: alsa dshare endless playback of buffer sutar.mounesh
2016-11-28 19:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).