alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com,
	tiwai@suse.de, mengdong.lin@intel.com, vinod.koul@intel.com,
	broonie@kernel.org, pierre-louis.bossart@intel.com
Subject: Re: [PATCH 1/2] ASoC: core: Add API to use DMI name in sound card long name
Date: Wed, 21 Dec 2016 15:01:56 +0000	[thread overview]
Message-ID: <1482332516.2554.103.camel@loki> (raw)
In-Reply-To: <9511f55d-8a49-7e32-7faf-9d3fa26820ca@linux.intel.com>

On Wed, 2016-12-21 at 08:37 -0600, Pierre-Louis Bossart wrote:
> > +
> > +     /* Add flavour to dmi long name */
> > +     if (flavour) {
> > +             strncat(card->dmi_longname, "-",
> > +                     sizeof(card->snd_card->longname));
> > +             strncat(card->dmi_longname, flavour,
> > +                     sizeof(card->snd_card->longname));
> > +     }
> 
> how is the 'flavour' defined? This doesn't seem to come from the DMI 
> decode information? Is this for example intended to be used with
> quirks?


Yes, it's intended for identifying quirks, different firmwares, etc

Liam

  reply	other threads:[~2016-12-21 15:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 13:02 [PATCH 0/2] ASoC: Use DMI name in sound card long name mengdong.lin
2016-12-21 13:04 ` [PATCH 1/2] ASoC: core: Add API to use " mengdong.lin
2016-12-21 14:27   ` Liam Girdwood
2016-12-21 15:46     ` Lin, Mengdong
2016-12-22  3:07       ` Mengdong Lin
2016-12-21 14:37   ` Pierre-Louis Bossart
2016-12-21 15:01     ` Liam Girdwood [this message]
2016-12-21 16:01     ` Lin, Mengdong
2016-12-21 13:04 ` [PATCH 2/2] ASoC: Intel: Use DMI name for sound card long name in Broadwell machine driver mengdong.lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482332516.2554.103.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=mengdong.lin@intel.com \
    --cc=mengdong.lin@linux.intel.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).