Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: alsa-devel@alsa-project.org
Cc: Jordi Mallach <jordi@debian.org>
Subject: [PATCH] alsactl: Check existence of `alsactl` in udev rule
Date: Wed, 28 Dec 2016 23:31:15 +0100	[thread overview]
Message-ID: <1482964275.11185.34.camel@users.sourceforge.net> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1536 bytes --]

From: Jordi Mallach <jordi@debian.org>
Date: Thu, 10 Jan 2013 00:17:58 +0000

Include the line `TEST=="/usr/sbin/alsactl"` in the udev rule, to
properly fix the state restoring for users with split `/usr`
filesystems
[1].

Upstream the patch from the Debian package [2].

[1] https://bugs.debian.org/670490
    "Debian Bug report logs - #670490 alsa-utils: Restore sound volume
     in udev"
[2] https://sources.debian.net/src/alsa-utils/1.1.2-1/debian/patches/udev_test_alsactl.patch/

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
CC: Jordi Mallach <jordi@debian.org>
---
Please apply with `git am saved-messages.mbox`.

 alsactl/90-alsa-restore.rules.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/alsactl/90-alsa-restore.rules.in b/alsactl/90-alsa-restore.rules.in
index c0c1b23..f190b85 100644
--- a/alsactl/90-alsa-restore.rules.in
+++ b/alsactl/90-alsa-restore.rules.in
@@ -2,7 +2,7 @@ ACTION=="add", SUBSYSTEM=="sound", KERNEL=="controlC*", KERNELS!="card*", TEST==
 GOTO="alsa_restore_end"
 
 LABEL="alsa_restore_go"
-TEST!="@daemonswitch@", RUN+="@sbindir@/alsactl restore $attr{device/number}"
-TEST=="@daemonswitch@", RUN+="@sbindir@/alsactl nrestore $attr{device/number}"
+TEST!="@daemonswitch@", TEST=="@sbindir@/alsactl", RUN+="@sbindir@/alsactl restore $attr{device/number}"
+TEST=="@daemonswitch@", TEST=="@sbindir@/alsactl", RUN+="@sbindir@/alsactl nrestore $attr{device/number}"
 
 LABEL="alsa_restore_end"
-- 
2.11.0

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2016-12-28 22:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28 22:31 Paul Menzel [this message]
2016-12-29 13:28 ` [PATCH] alsactl: Check existence of `alsactl` in udev rule Takashi Iwai
2016-12-30 10:04   ` Paul Menzel
2016-12-30 10:16     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482964275.11185.34.camel@users.sourceforge.net \
    --to=paulepanter@users.sourceforge.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=jordi@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox