alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: jeeja.kp@intel.com
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com, broonie@kernel.org,
	liam.r.girdwood@intel.com, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH v4 8/9] ASoC: Intel: Skylake: set the resume point to LPIB
Date: Mon,  2 Jan 2017 12:44:35 +0530	[thread overview]
Message-ID: <1483341277-14475-9-git-send-email-jeeja.kp@intel.com> (raw)
In-Reply-To: <1483341277-14475-1-git-send-email-jeeja.kp@intel.com>

From: Jeeja KP <jeeja.kp@intel.com>

In system suspend, the firmware pipelines will be deleted and there
is no need to save the pipeline context. Driver will save the DPIB and
LPIB pointers in suspend.

In system resume, the firmware pipelines will be created again and the
RD/RW pointers in the Firmware buffer points to the base address. So
need to fetch the non-played data again to firmware buffer. LPIB
indicates the HW rendered position.

Instead of setting DPIB as resume point, set it to LPIB to restore from
the HW render position so that DMA would fetch the non-played data one
more time.

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
---
 sound/soc/intel/skylake/skl-pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 800fdad..508144b 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -484,7 +484,7 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
 			snd_hdac_ext_stream_drsm_enable(ebus, true,
 						hdac_stream(stream)->index);
 			snd_hdac_ext_stream_set_dpibr(ebus, stream,
-							stream->dpib);
+							stream->lpib);
 			snd_hdac_ext_stream_set_lpib(stream, stream->lpib);
 		}
 
-- 
2.5.0

  parent reply	other threads:[~2017-01-02  7:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02  7:14 [PATCH v4 0/9] ASoC: Intel: Skylake: Driver updates jeeja.kp
2017-01-02  7:14 ` [PATCH v4 1/9] ALSA: hda: check stream decoupled register state jeeja.kp
2017-01-02  7:14 ` [PATCH v4 2/9] ASoC: Intel: Skylake: Add set_tristate DAI ops to enable SSP MCLK jeeja.kp
2017-01-06 18:32   ` Mark Brown
2017-01-10  9:31     ` Jeeja KP
2017-01-02  7:14 ` [PATCH v4 3/9] ASoC: Intel: Skylake: Remove unused SSP BE prepare DAI ops jeeja.kp
2017-01-02  7:14 ` [PATCH v4 4/9] ASoC: Intel: Skylake: Add supply widget as non DSP widget jeeja.kp
2017-01-02  7:14 ` [PATCH v4 5/9] ASoC: Intel: Skylake: Add supply widget in skl_nau_max machine jeeja.kp
2017-01-02  7:14 ` [PATCH v4 6/9] ASoC: Intel: Skylake: Add supply widget in bxt_da_max machine jeeja.kp
2017-01-06 18:34   ` Mark Brown
2017-01-02  7:14 ` [PATCH v4 7/9] ASoC: Intel: Skylake: Don't reset pass-through pipe in BE prepare jeeja.kp
2017-01-02  7:14 ` jeeja.kp [this message]
2017-01-02  7:14 ` [PATCH v4 9/9] ASoC: hdac_hdmi: Enable pin and converter in prepare jeeja.kp
2017-01-19 18:03   ` Applied "ASoC: hdac_hdmi: Enable pin and converter in prepare" to the asoc tree Mark Brown
2017-01-02 10:01 ` [PATCH v4 0/9] ASoC: Intel: Skylake: Driver updates Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483341277-14475-9-git-send-email-jeeja.kp@intel.com \
    --to=jeeja.kp@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).