From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Boyd <sboyd@codeaurora.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: linux-clk@vger.kernel.org, x86@kernel.org,
platform-driver-x86@vger.kernel.org,
Darren Hart <dvhart@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
alsa-devel@alsa-project.org,
Irina Tirdea <irina.tirdea@intel.com>,
Michael Turquette <mturquette@baylibre.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, Mark Brown <broonie@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>, Len Brown <lenb@kernel.org>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks
Date: Sat, 21 Jan 2017 15:56:20 +0200 [thread overview]
Message-ID: <1485006980.2133.279.camel@linux.intel.com> (raw)
In-Reply-To: <20170120235856.GF20800@codeaurora.org>
On Fri, 2017-01-20 at 15:58 -0800, Stephen Boyd wrote:
> On 01/17, Pierre-Louis Bossart wrote:
> >
> > +static void plt_clk_reg_update(struct clk_plt *clk, u32 mask, u32
> > val)
> > +{
> > + u32 tmp;
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&clk->lock, flags);
> > +
> > + tmp = clk_readl(clk->reg);
>
> Do you need to use clk_readl? I'd prefer we deleted that
> function/macro because it's just confusing.
Good to know.
> Please don't use it
> unless you need it for some reason.
It was my suggestion, I didn't know that the mentioned API is kinda
deprecated.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-01-21 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 21:57 [PATCH v7 0/5] Add platform clock for BayTrail platforms Pierre-Louis Bossart
2017-01-17 21:57 ` [PATCH v7 1/5] clk: Make x86/ conditional on CONFIG_COMMON_CLK Pierre-Louis Bossart
2017-01-17 21:57 ` [PATCH v7 2/5] clk: x86: Add Atom PMC platform clocks Pierre-Louis Bossart
2017-01-20 23:58 ` Stephen Boyd
2017-01-21 13:56 ` Andy Shevchenko [this message]
2017-01-21 16:28 ` [alsa-devel] " Pierre-Louis Bossart
2017-01-17 21:57 ` [PATCH v7 3/5] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Pierre-Louis Bossart
2017-01-18 9:28 ` Thomas Gleixner
2017-01-17 21:57 ` [PATCH v7 4/5] platform/x86: Enable Atom PMC platform clocks Pierre-Louis Bossart
2017-01-17 21:57 ` [PATCH v7 5/5] platform/x86: fix typo in comment Pierre-Louis Bossart
2017-01-18 10:50 ` [PATCH v7 0/5] Add platform clock for BayTrail platforms Andy Shevchenko
2017-01-21 0:00 ` Stephen Boyd
2017-01-21 10:53 ` Andy Shevchenko
2017-01-27 0:17 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485006980.2133.279.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).