alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org
Cc: tiwai@suse.de, Daniel Vetter <daniel.vetter@ffwll.ch>,
	broonie@kernel.org
Subject: [RFC PATCH 5/5] ALSA: x86: hdmi: hack to enable DP audio on CHT
Date: Thu, 26 Jan 2017 14:05:41 -0600	[thread overview]
Message-ID: <1485461141-14023-6-git-send-email-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <1485461141-14023-1-git-send-email-pierre-louis.bossart@linux.intel.com>

Somehow the configuration register that the audio driver needs to use
depends on the port/pipe combination.
Adding the pipe information to the notify() call isn't helping, the
pipe value is -1 (illegal).

FIXME: does this require a change in the pdata or a handshake with i915?
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/x86/intel_hdmi_lpe_audio.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/sound/x86/intel_hdmi_lpe_audio.c b/sound/x86/intel_hdmi_lpe_audio.c
index 6ef0ff8..23e5b34 100644
--- a/sound/x86/intel_hdmi_lpe_audio.c
+++ b/sound/x86/intel_hdmi_lpe_audio.c
@@ -563,7 +563,13 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
 	if (pci_dev_present(cherryview_ids)) {
 		dev_dbg(&hlpe_pdev->dev, "%s: Cherrytrail LPE - Detected\n",
 				__func__);
-		ctx->had_config_offset = AUDIO_HDMI_CONFIG_C;
+		//ctx->had_config_offset = AUDIO_HDMI_CONFIG_C;
+		/* FIXME: hard-coding to CONFIG_A enables DP audio on CHT,
+		 *  how do I find out which config to use ?
+		 * the pipe is -1 (invalid) when the notify function is called,
+		 * so not sure how to go about this
+		 */
+		ctx->had_config_offset = AUDIO_HDMI_CONFIG_A;
 	} else {
 		dev_dbg(&hlpe_pdev->dev, "%s: Baytrail LPE - Assume\n",
 				__func__);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-01-26 20:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 20:05 [RFC PATCH 0/5] DisplayPort Audio on Cherrytrail Pierre-Louis Bossart
2017-01-26 20:05 ` [RFC PATCH 1/5] drm: i915: add DP support in LPE audio mode Pierre-Louis Bossart
2017-01-26 20:05 ` [RFC PATCH 2/5] ALSA: x86: intel_hdmi: add definitions and logic for DP audio Pierre-Louis Bossart
2017-01-26 20:05 ` [RFC PATCH 3/5] ALSA: x86: intel_hdmi: set config bitfields for DP mode Pierre-Louis Bossart
2017-01-26 20:05 ` [RFC PATCH 4/5] drm: i915: add DisplayPort amp unmute for LPE audio mode Pierre-Louis Bossart
2017-01-27 10:08   ` Jani Nikula
2017-01-27 13:17     ` Ville Syrjälä
2017-01-27 13:51       ` Jani Nikula
2017-01-27 13:55         ` Ville Syrjälä
2017-01-27 14:35       ` Ville Syrjälä
2017-01-27 14:42         ` Takashi Iwai
2017-01-27 14:55           ` Pierre-Louis Bossart
2017-01-27 15:46             ` Ville Syrjälä
2017-01-27 14:47       ` Pierre-Louis Bossart
2017-01-27 15:17         ` Ville Syrjälä
2017-01-26 20:05 ` Pierre-Louis Bossart [this message]
2017-01-27 10:26 ` [RFC PATCH 0/5] DisplayPort Audio on Cherrytrail Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485461141-14023-6-git-send-email-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).