* [PATCH 6/6 V2] pcm:plug: save converter config
@ 2017-02-27 7:27 sutar.mounesh
0 siblings, 0 replies; only message in thread
From: sutar.mounesh @ 2017-02-27 7:27 UTC (permalink / raw)
To: patch; +Cc: Mounesh Sutar, alsa-devel, Andreas Pape, mounesh_sutar
From: Andreas Pape <apape@de.adit-jv.com>
Passed config is freed after call to open, thus it is invalid when
trying to extract the converter name. So config entry is saved
for later usage.
Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
Signed-off-by: Mounesh Sutar <sutar.mounesh@gmail.com>
diff --git a/src/pcm/pcm_plug.c b/src/pcm/pcm_plug.c
index 266707b..ad0e99e 100644
--- a/src/pcm/pcm_plug.c
+++ b/src/pcm/pcm_plug.c
@@ -64,6 +64,8 @@ static int snd_pcm_plug_close(snd_pcm_t *pcm)
snd_pcm_plug_t *plug = pcm->private_data;
int err, result = 0;
free(plug->ttable);
+ if (plug->rate_converter)
+ snd_config_delete((snd_config_t*)plug->rate_converter);
assert(plug->gen.slave == plug->req_slave);
if (plug->gen.close_slave) {
snd_pcm_unlink_hw_ptr(pcm, plug->req_slave);
@@ -1108,7 +1110,13 @@ int snd_pcm_plug_open(snd_pcm_t **pcmp,
plug->sformat = sformat;
plug->schannels = schannels;
plug->srate = srate;
- plug->rate_converter = rate_converter;
+ if (rate_converter) {
+ if ((err = snd_config_copy((snd_config_t**)&plug->rate_converter,
+ (snd_config_t *)rate_converter)) < 0)
+ free(plug);
+ return err;
+ }
+
plug->gen.slave = plug->req_slave = slave;
plug->gen.close_slave = close_slave;
plug->route_policy = route_policy;
@@ -1119,6 +1127,8 @@ int snd_pcm_plug_open(snd_pcm_t **pcmp,
err = snd_pcm_new(&pcm, SND_PCM_TYPE_PLUG, name, slave->stream, slave->mode);
if (err < 0) {
+ if (plug->rate_converter)
+ snd_config_delete((snd_config_t*)plug->rate_converter);
free(plug);
return err;
}
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-27 7:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-27 7:27 [PATCH 6/6 V2] pcm:plug: save converter config sutar.mounesh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).