From: jeeja.kp@intel.com
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, G Kranthi <gudishax.kranthikumar@intel.com>,
patches.audio@intel.com, broonie@kernel.org,
liam.r.girdwood@intel.com, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 07/10] ASoC: Intel: Skylake: Disable notifications at boot after DSP FW init
Date: Tue, 7 Mar 2017 23:44:03 +0530 [thread overview]
Message-ID: <1488910446-26415-8-git-send-email-jeeja.kp@intel.com> (raw)
In-Reply-To: <1488910446-26415-1-git-send-email-jeeja.kp@intel.com>
From: G Kranthi <gudishax.kranthikumar@intel.com>
DSP firmware sends notification every 1m, which is disabled in runtime
suspend. But if a system has no runtime pm, we keep getting
notification, so disable after FW init as well.
Signed-off-by: G Kranthi <gudishax.kranthikumar@intel.com>
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
---
sound/soc/intel/skylake/skl-messages.c | 2 +-
sound/soc/intel/skylake/skl-pcm.c | 1 +
sound/soc/intel/skylake/skl-sst-dsp.h | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index ed57696..29523dd 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -58,7 +58,7 @@ static int skl_free_dma_buf(struct device *dev, struct snd_dma_buffer *dmab)
#define NOTIFICATION_MASK 0xf
/* disable notfication for underruns/overruns from firmware module */
-static void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable)
+void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable)
{
struct notification_mask mask;
struct skl_ipc_large_config_msg msg = {0};
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index a5d46f7..270fec7 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -1214,6 +1214,7 @@ static int skl_platform_soc_probe(struct snd_soc_platform *platform)
}
skl_populate_modules(skl);
skl->skl_sst->update_d0i3c = skl_update_d0i3c;
+ skl_dsp_enable_notification(skl->skl_sst, false);
}
pm_runtime_mark_last_busy(platform->dev);
pm_runtime_put_autosuspend(platform->dev);
diff --git a/sound/soc/intel/skylake/skl-sst-dsp.h b/sound/soc/intel/skylake/skl-sst-dsp.h
index 849410d..e8d1e14 100644
--- a/sound/soc/intel/skylake/skl-sst-dsp.h
+++ b/sound/soc/intel/skylake/skl-sst-dsp.h
@@ -235,4 +235,6 @@ int skl_get_pvt_instance_id_map(struct skl_sst *ctx,
void skl_freeup_uuid_list(struct skl_sst *ctx);
int skl_dsp_strip_extended_manifest(struct firmware *fw);
+void skl_dsp_enable_notification(struct skl_sst *ctx, bool enable);
+
#endif /*__SKL_SST_DSP_H__*/
--
2.5.0
next prev parent reply other threads:[~2017-03-07 18:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 18:13 [PATCH 00/10] ASoC: Intel: Skylake: Driver updates jeeja.kp
2017-03-07 18:13 ` [PATCH 01/10] ASoC: Intel: Skylake: Fix to delete DSP pipe after stopping pipe jeeja.kp
2017-03-09 6:17 ` Vinod Koul
2017-03-07 18:13 ` [PATCH 02/10] ASoC: Intel: Skylake: Fix not to stop src pipe in pre pmd event handler jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: Skylake: Fix not to stop src pipe in pre pmd event handler" to the asoc tree Mark Brown
2017-03-07 18:13 ` [PATCH 03/10] ASoC: Intel: bxtn: Disable interrupt when DSP is in D3 jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: bxtn: Disable interrupt when DSP is in D3" to the asoc tree Mark Brown
2017-03-07 18:14 ` [PATCH 04/10] ASoC: Intel: bxtn: Update DSP core state in D0 jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: bxtn: Update DSP core state in D0" to the asoc tree Mark Brown
2017-03-07 18:14 ` [PATCH 05/10] ASoC: Intel: bxtn: Reload the firmware in case of D3 failure jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: bxtn: Reload the firmware in case of D3 failure" to the asoc tree Mark Brown
2017-03-07 18:14 ` [PATCH 06/10] ASoC: Intel: Skylake: Remove BE prepare ops jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: Skylake: Remove BE prepare ops" to the asoc tree Mark Brown
2017-03-07 18:14 ` jeeja.kp [this message]
2017-03-09 6:17 ` [PATCH 07/10] ASoC: Intel: Skylake: Disable notifications at boot after DSP FW init Vinod Koul
2017-03-15 18:13 ` Applied "ASoC: Intel: Skylake: Disable notifications at boot after DSP FW init" to the asoc tree Mark Brown
2017-03-07 18:14 ` [PATCH 08/10] ASoC: Intel: Skylake: Remove get dsp_ops in cleanup routine jeeja.kp
2017-03-10 4:40 ` kbuild test robot
2017-03-07 18:14 ` [PATCH 09/10] ASoC: Intel: Skylake: Fix module load when module size > DMA buffer size jeeja.kp
2017-03-07 18:14 ` [PATCH 10/10] ASoC: Intel: Skylake: Fix parameter overwrite for KPB Module jeeja.kp
2017-03-15 18:13 ` Applied "ASoC: Intel: Skylake: Fix parameter overwrite for KPB Module" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488910446-26415-8-git-send-email-jeeja.kp@intel.com \
--to=jeeja.kp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gudishax.kranthikumar@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).