alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: jeeja.kp@intel.com
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Guneshwor Singh <guneshwor.o.singh@intel.com>,
	patches.audio@intel.com, broonie@kernel.org,
	liam.r.girdwood@intel.com, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH V2 02/10] ASoC: Intel: Skylake: Fix not to stop src pipe in pre pmd event handler
Date: Mon, 13 Mar 2017 22:11:24 +0530	[thread overview]
Message-ID: <1489423292-19997-3-git-send-email-jeeja.kp@intel.com> (raw)
In-Reply-To: <1489423292-19997-1-git-send-email-jeeja.kp@intel.com>

From: Guneshwor Singh <guneshwor.o.singh@intel.com>

If the widget is a mixin module, just unbind between source and sink
and don't stop the source pipe as there can be multiple sinks
connected.

Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
---
 sound/soc/intel/skylake/skl-topology.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index f38f8e6..f04a251 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -975,15 +975,6 @@ static int skl_tplg_mixer_dapm_pre_pmd_event(struct snd_soc_dapm_widget *w,
 			src_mconfig = sink_mconfig->m_in_pin[i].tgt_mcfg;
 			if (!src_mconfig)
 				continue;
-			/*
-			 * If path_found == 1, that means pmd for source
-			 * pipe has not occurred, source is connected to
-			 * some other sink. so its responsibility of sink
-			 * to unbind itself from source.
-			 */
-			ret = skl_stop_pipe(ctx, src_mconfig->pipe);
-			if (ret < 0)
-				return ret;
 
 			ret = skl_unbind_modules(ctx,
 						src_mconfig, sink_mconfig);
-- 
2.5.0

  parent reply	other threads:[~2017-03-13 16:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 16:41 [PATCH V2 00/10] ASoC: Intel: Skylake: Driver updates jeeja.kp
2017-03-13 16:41 ` [PATCH V2 01/10] ASoC: Intel: Skylake: Fix to delete DSP pipe after stopping pipe jeeja.kp
2017-03-13 16:41 ` jeeja.kp [this message]
2017-03-13 16:41 ` [PATCH V2 03/10] ASoC: Intel: bxtn: Disable interrupt when DSP is in D3 jeeja.kp
2017-03-13 16:41 ` [PATCH V2 04/10] ASoC: Intel: bxtn: Update DSP core state in D0 jeeja.kp
2017-03-13 16:41 ` [PATCH V2 05/10] ASoC: Intel: bxtn: Reload the firmware in case of D3 failure jeeja.kp
2017-03-13 16:41 ` [PATCH V2 06/10] ASoC: Intel: Skylake: Remove BE prepare ops jeeja.kp
2017-03-13 16:41 ` [PATCH V2 07/10] ASoC: Intel: Skylake: Disable notifications at boot after DSP FW init jeeja.kp
2017-03-13 16:41 ` [PATCH V2 08/10] ASoC: Intel: Skylake: Remove get dsp_ops in cleanup routine jeeja.kp
2017-03-15 18:13   ` Applied "ASoC: Intel: Skylake: Remove get dsp_ops in cleanup routine" to the asoc tree Mark Brown
2017-03-13 16:41 ` [PATCH V2 09/10] ASoC: Intel: Skylake: Fix module load when module size > DMA buffer size jeeja.kp
2017-03-15 18:13   ` Applied "ASoC: Intel: Skylake: Fix module load when module size > DMA buffer size" to the asoc tree Mark Brown
2017-03-13 16:41 ` [PATCH V2 10/10] ASoC: Intel: Skylake: Fix parameter overwrite for KPB Module jeeja.kp
2017-03-14  5:00 ` [PATCH V2 00/10] ASoC: Intel: Skylake: Driver updates Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489423292-19997-3-git-send-email-jeeja.kp@intel.com \
    --to=jeeja.kp@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=guneshwor.o.singh@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).