Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

From: Daniel Baluta <daniel.baluta@nxp.com>
To: "arnd@arndb.de" <arnd@arndb.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@opensource.wolfsonmicro.com"
	<patches@opensource.wolfsonmicro.com>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"ckeepax@opensource.wolfsonmicro.com"
	<ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning
Date: Thu, 27 Apr 2017 11:02:52 +0000	[thread overview]
Message-ID: <1493290972.18400.40.camel@nxp.com> (raw)
In-Reply-To: <CAK8P3a1ZGTyjhAzy4h2D10+-dFNi6o_qe0pY9Wx5wYXZK6ObDw@mail.gmail.com>

On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote:
> On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta <daniel.baluta@nxp.com
> > wrote:
> > 
> > The new PLL configuration code triggers a harmless warning:
> > 
> > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking':
> > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used
> > uninitialized in this function [-Werror=maybe-uninitialized]
> >    wm8960_set_pll(codec, freq_in, best_freq_out);
> >    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > sound/soc/codecs/wm8960.c:699:12: note: 'best_freq_out' was
> > declared
> > here
> > 
> > Fix this by reworking the code such that:
> > 
> > 1) When there is no PLL freq available return -EINVAL and make
> > sure *bclk_idx, *dac_idx, *sysclk_idx are initialized with
> > invalid values.
> > 
> > 2) When there is a PLL freq available initialize *bclk_idx,
> > *dac_idx and *sysclk_idx with correct values and immediately
> > return the freq available.
> > 
> > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq
> > search")
> > Fixes: 303e8954af8d ("ASoC: codec: wm8960: Stop when a matching PLL
> > freq is found")
> > Suggested-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> Looks good to me. Let me know if you need me to test this more
> thoroughly
> with randconfig builds, otherwise I'll assume it's fine and it will
> get tested once
> it shows up in linux-next.
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 

Hi Arnd, 

Thanks for doing this. I wouldn't expect randconfigs builds to show
other issues.

Anyhow, would like to see if with your compiler there are no warnings
for the second patch of the series:

http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120177.html

thanks,
Daniel.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel