From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: dapm: Add new widget type for constructing DAPM graphs on DSPs.
Date: Wed, 07 Jun 2017 21:00:51 +0100 [thread overview]
Message-ID: <1496865651.31880.133.camel@loki> (raw)
In-Reply-To: <20170607192304.thekfsvzy7mc7lgl@sirena.org.uk>
On Wed, 2017-06-07 at 20:23 +0100, Mark Brown wrote:
> On Tue, Jun 06, 2017 at 03:44:42PM +0100, Liam Girdwood wrote:
>
> > + snd_soc_dapm_buffer, /* DSP/CODEC internal buffer */
> > + snd_soc_dapm_pipeline, /* DSP/CODEC internal pipeline */
> > + snd_soc_dapm_effect, /* DSP/CODEC effect component */
>
> What's the difference between a buffer and a pipeline, or between a
> pipeline and an effect? We should have clear documentation, if they're
> different we're probably going to end up using them differently in the
> core at some point and if people use the wrong widget type it might end
> up breaking things.
Yes, that's a good point. I'll do a V2 that includes some documentation.
>
> > + snd_soc_dapm_codec, /* FW/SW coder/decoder component */
>
> Can we call this a fmt_conv or something? CODEC is unfortunately a bit
> overloaded.
True, what about snd_soc_dapm_media_codec ? or _sw_codec ? or
_media_decoder ?
Liam
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-06-07 20:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 14:44 [PATCH] ASoC: dapm: Add new widget type for constructing DAPM graphs on DSPs Liam Girdwood
2017-06-07 19:23 ` Mark Brown
2017-06-07 20:00 ` Liam Girdwood [this message]
2017-06-07 21:23 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496865651.31880.133.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox