* [PATCH] topology: delete output file if parsing fails.
@ 2017-06-09 15:33 Liam Girdwood
2017-06-10 9:35 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2017-06-09 15:33 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Liam Girdwood, alsa-devel
Currently the binary output file is left when parsing fails. This confuses
GNU Make if the parsing fails and causes the compilation to partially
complete.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---
topology/topology.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/topology/topology.c b/topology/topology.c
index 6d876ee..097c255 100644
--- a/topology/topology.c
+++ b/topology/topology.c
@@ -108,6 +108,7 @@ int main(int argc, char *argv[])
if (err < 0) {
fprintf(stderr, _("failed to compile context %s\n"), source_file);
snd_tplg_free(snd_tplg);
+ unlink(output_file);
return 1;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] topology: delete output file if parsing fails.
2017-06-09 15:33 [PATCH] topology: delete output file if parsing fails Liam Girdwood
@ 2017-06-10 9:35 ` Takashi Iwai
2017-06-12 17:44 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2017-06-10 9:35 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel
On Fri, 09 Jun 2017 17:33:42 +0200,
Liam Girdwood wrote:
>
> Currently the binary output file is left when parsing fails. This confuses
> GNU Make if the parsing fails and causes the compilation to partially
> complete.
>
> Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Applied, thanks.
But at the next time, please specify which repo to apply.
It took some time until I figured out it's for alsa-utils.
Takashi
> ---
> topology/topology.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/topology/topology.c b/topology/topology.c
> index 6d876ee..097c255 100644
> --- a/topology/topology.c
> +++ b/topology/topology.c
> @@ -108,6 +108,7 @@ int main(int argc, char *argv[])
> if (err < 0) {
> fprintf(stderr, _("failed to compile context %s\n"), source_file);
> snd_tplg_free(snd_tplg);
> + unlink(output_file);
> return 1;
> }
>
> --
> 2.11.0
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] topology: delete output file if parsing fails.
2017-06-10 9:35 ` Takashi Iwai
@ 2017-06-12 17:44 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2017-06-12 17:44 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
On Sat, 2017-06-10 at 11:35 +0200, Takashi Iwai wrote:
> On Fri, 09 Jun 2017 17:33:42 +0200,
> Liam Girdwood wrote:
> >
> > Currently the binary output file is left when parsing fails. This confuses
> > GNU Make if the parsing fails and causes the compilation to partially
> > complete.
> >
> > Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>
> Applied, thanks.
>
> But at the next time, please specify which repo to apply.
> It took some time until I figured out it's for alsa-utils.
Apologies, I was doing some alsa-lib patches at the same time. This did
make me realize we do have some other similar named areas that overlap
in the kernel and in alsa-lib, but they are probably manageable for the
moment.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-12 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 15:33 [PATCH] topology: delete output file if parsing fails Liam Girdwood
2017-06-10 9:35 ` Takashi Iwai
2017-06-12 17:44 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).