Re: [PATCH v2] ASoC: Intel: byt-max98090: Add GPIO ACPI mapping table

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sat, 2017-06-10 at 21:41 +0200, Takashi Iwai wrote:
> On Sat, 10 Jun 2017 18:37:41 +0200,
> Andy Shevchenko wrote:
> > 
> > +static const struct acpi_gpio_params hp_gpios = { 0, 0, false };
> > +static const struct acpi_gpio_params mic_gpios = { 1, 0, false };
> > +
> > +static const struct acpi_gpio_mapping acpi_byt_max98090_gpios[] = {
> > +	{ "hp-gpios", &hp_gpios, 1 },
> > +	{ "mic-gpios", &mic_gpios, 1 },
> 
> Better to use C99 style init?

Here it makes a little advantage over more uglified code.

>   I'm not always a fan of it, but this
> seems deserving.  From the above, it's difficult to know which zero is
> for what.

I'm not sure it makes sense. Those fields are filed according to ACPI
specification and applies to the platform in question. Usually you don't
need to look into them on regular basis, perhaps one time per each
platform which uses such combination of SoC + ASoC + Codec which is
quite unlikely to be more than once twice per year(?).

So, for over few dozens of drivers which are using GPIO ACPI mapping
tables this is the first request like this I see.

Thus, if you insist, I can do it, but my vote is "it doesn't worth of
doing it at all".

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel