alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v2] ASoC: dapm: Add new widget type for constructing DAPM graphs on DSPs.
Date: Thu, 15 Jun 2017 11:56:39 +0100	[thread overview]
Message-ID: <1497524199.30929.378.camel@loki> (raw)
In-Reply-To: <20170615100124.vegs5xwkvbzqtq7z@sirena.org.uk>

On Thu, 2017-06-15 at 11:01 +0100, Mark Brown wrote:
> On Wed, Jun 14, 2017 at 12:28:55PM +0100, Liam Girdwood wrote:
> > On Fri, 2017-06-09 at 18:53 +0100, Mark Brown wrote:
> 
> > > I'm still a bit unclear about how a pipeline and effect are different
> > > from an ASoC point of view - it matters on the DSP but from the kernel's
> > > point of view a pipeline just an effect that happens to have a more
> > > complicated implementation on the DSP?
> 
> > Yes, that's true, some of the objects will most likely be treated the
> > same by the kernel core but for the DSP and driver they will different.
> > i.e. they create different objects with different topology private data
> > (using the widget ID to differentiate).
> 
> Shouldn't that just be handled in the driver though?  Nothing outside
> the driver cares.  We're going to need to differentiate between
> different effects and pipelines in the driver anyway.

It can be, just a little more code in the driver that's all. I'll remove
the pipeline widget and resend.

Thanks

Liam

      reply	other threads:[~2017-06-15 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 15:23 [PATCH v2] ASoC: dapm: Add new widget type for constructing DAPM graphs on DSPs Liam Girdwood
2017-06-09 17:53 ` Mark Brown
2017-06-14 11:28   ` Liam Girdwood
2017-06-15 10:01     ` Mark Brown
2017-06-15 10:56       ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1497524199.30929.378.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).