From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
alsa-devel@alsa-project.org, John Keeping <john@metanate.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v2 3/3] ASoC: rt5677: Remove never used variables
Date: Wed, 19 Jul 2017 14:48:33 +0300 [thread overview]
Message-ID: <1500464913.29303.105.camel@linux.intel.com> (raw)
In-Reply-To: <20170719112412.wrqgdk7typqie72d@sirena.org.uk>
On Wed, 2017-07-19 at 12:24 +0100, Mark Brown wrote:
> On Tue, Jul 18, 2017 at 08:34:19PM +0300, Andy Shevchenko wrote:
> > There are two variables that have never been used.
> >
> > sound/soc/codecs/rt5677.c:785:35: warning: ‘in_vol_tlv’ defined but
> > not used [-Wunused-const-variable=]
> > static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -3450, 150, 0);
> >
> > sound/soc/codecs/rt5677.c:783:35: warning: ‘out_vol_tlv’ defined but
> > not used [-Wunused-const-variable=]
> > static const DECLARE_TLV_DB_SCALE(out_vol_tlv, -4650, 150, 0);
> >
> > Simple remove them.
>
> Are we sure this doesn't mean something has the wrong TLV or a missing
> TLV?
Good question.
If it so, it should not have been working (properly) at the beginning.
Guys from Realtek, can you comment on this?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-07-19 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 17:34 [PATCH v2 0/3] ASoC: rt5677: Few clean ups to the driver Andy Shevchenko
2017-07-18 17:34 ` [PATCH v2 1/3] ASoC: rt5677: Hide platform data in the module sources Andy Shevchenko
2017-07-19 11:27 ` Applied "ASoC: rt5677: Hide platform data in the module sources" to the asoc tree Mark Brown
2017-07-18 17:34 ` [PATCH v2 2/3] ASoC: rt5677: Refactor code to avoid comparison unsigned >= 0 Andy Shevchenko
2017-07-19 11:27 ` Applied "ASoC: rt5677: Refactor code to avoid comparison unsigned >= 0" to the asoc tree Mark Brown
2017-07-18 17:34 ` [PATCH v2 3/3] ASoC: rt5677: Remove never used variables Andy Shevchenko
2017-07-19 11:24 ` Mark Brown
2017-07-19 11:48 ` Andy Shevchenko [this message]
2017-07-20 1:47 ` Oder Chiou
2017-07-20 12:23 ` Applied "ASoC: rt5677: Remove never used variables" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500464913.29303.105.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=john@metanate.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).