From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org,
krzk@kernel.org, sbkim73@samsung.com, lgirdwood@gmail.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 03/11] ASoC: samsung: pcm: Handle return value of clk_prepare_enable.
Date: Tue, 25 Jul 2017 15:44:30 +0530 [thread overview]
Message-ID: <1500977674-27960-4-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500977674-27960-1-git-send-email-arvind.yadav.cs@gmail.com>
clk_prepare_enable() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/soc/samsung/pcm.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
index d50a637..37f95ee 100644
--- a/sound/soc/samsung/pcm.c
+++ b/sound/soc/samsung/pcm.c
@@ -522,7 +522,9 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to get audio-bus clock\n");
return PTR_ERR(pcm->cclk);
}
- clk_prepare_enable(pcm->cclk);
+ ret = clk_prepare_enable(pcm->cclk);
+ if (ret)
+ return ret;
/* record our pcm structure for later use in the callbacks */
dev_set_drvdata(&pdev->dev, pcm);
@@ -533,7 +535,9 @@ static int s3c_pcm_dev_probe(struct platform_device *pdev)
ret = PTR_ERR(pcm->pclk);
goto err_dis_cclk;
}
- clk_prepare_enable(pcm->pclk);
+ ret = clk_prepare_enable(pcm->pclk);
+ if (ret)
+ goto err_dis_cclk;
s3c_pcm_stereo_in[pdev->id].addr = mem_res->start + S3C_PCM_RXFIFO;
s3c_pcm_stereo_out[pdev->id].addr = mem_res->start + S3C_PCM_TXFIFO;
--
1.9.1
next prev parent reply other threads:[~2017-07-25 10:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 10:14 [PATCH 00/11] Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 10:14 ` [PATCH 01/11] ASoC: samsung: s3c2412: " Arvind Yadav
2017-07-25 17:43 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: s3c2412: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-26 15:46 ` Krzysztof Kozlowski
2017-07-26 16:07 ` Mark Brown
2017-07-26 16:13 ` Krzysztof Kozlowski
2017-07-25 10:14 ` [PATCH 02/11] ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 17:50 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: s3c24xx: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` Arvind Yadav [this message]
2017-07-25 17:51 ` [PATCH 03/11] ASoC: samsung: pcm: Handle return value of clk_prepare_enable Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: pcm: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 04/11] ASoC: samsung: i2s: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 17:58 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: i2s: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 05/11] ASoC: samsung: spdif: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-25 18:01 ` Krzysztof Kozlowski
2017-07-26 14:17 ` Applied "ASoC: samsung: spdif: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 06/11] ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare Arvind Yadav
2017-07-26 14:16 ` Applied "ASoC: mxs-saif: Handle return value of clk_prepare_enable/clk_prepare." to the asoc tree Mark Brown
2017-07-25 10:14 ` [PATCH 07/11] ASoC: jz4740: Handle return value of clk_prepare_enable Arvind Yadav
2017-07-26 14:16 ` Applied "ASoC: jz4740: Handle return value of clk_prepare_enable." to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500977674-27960-4-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).