From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: perex@perex.cz, tiwai@suse.com, johannes@sipsolutions.net,
linux@armlinux.org.uk, daniel@zonque.org, clemens@ladisch.de
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH 05/13] ALSA: firewire: constify snd_pcm_ops structures
Date: Fri, 18 Aug 2017 13:15:13 +0530 [thread overview]
Message-ID: <1503042321-26758-6-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1503042321-26758-1-git-send-email-arvind.yadav.cs@gmail.com>
snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
sound/firewire/isight.c | 2 +-
sound/firewire/motu/motu-pcm.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/firewire/isight.c b/sound/firewire/isight.c
index 48d6dca..5826aa8 100644
--- a/sound/firewire/isight.c
+++ b/sound/firewire/isight.c
@@ -444,7 +444,7 @@ static snd_pcm_uframes_t isight_pointer(struct snd_pcm_substream *substream)
static int isight_create_pcm(struct isight *isight)
{
- static struct snd_pcm_ops ops = {
+ static const struct snd_pcm_ops ops = {
.open = isight_open,
.close = isight_close,
.ioctl = snd_pcm_lib_ioctl,
diff --git a/sound/firewire/motu/motu-pcm.c b/sound/firewire/motu/motu-pcm.c
index a2b50df..1466e46 100644
--- a/sound/firewire/motu/motu-pcm.c
+++ b/sound/firewire/motu/motu-pcm.c
@@ -352,7 +352,7 @@ static int playback_ack(struct snd_pcm_substream *substream)
int snd_motu_create_pcm_devices(struct snd_motu *motu)
{
- static struct snd_pcm_ops capture_ops = {
+ static const struct snd_pcm_ops capture_ops = {
.open = pcm_open,
.close = pcm_close,
.ioctl = snd_pcm_lib_ioctl,
@@ -365,7 +365,7 @@ int snd_motu_create_pcm_devices(struct snd_motu *motu)
.page = snd_pcm_lib_get_vmalloc_page,
.mmap = snd_pcm_lib_mmap_vmalloc,
};
- static struct snd_pcm_ops playback_ops = {
+ static const struct snd_pcm_ops playback_ops = {
.open = pcm_open,
.close = pcm_close,
.ioctl = snd_pcm_lib_ioctl,
--
1.9.1
next prev parent reply other threads:[~2017-08-18 7:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 7:45 [PATCH 00/13] constify alsa snd_pcm_ops structures Arvind Yadav
2017-08-18 7:45 ` [PATCH 01/13] ALSA: aoa: constify " Arvind Yadav
2017-08-18 7:45 ` [PATCH 02/13] ALSA: arm: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 03/13] ALSA: atmel: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 04/13] ALSA: drivers: " Arvind Yadav
2017-08-18 7:45 ` Arvind Yadav [this message]
2017-08-18 7:45 ` [PATCH 06/13] ALSA: mips: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 07/13] ALSA: parisc: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 08/13] ALSA: pcmcia: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 13/13] ALSA: usb: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 09/13] ALSA: ppc: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 10/13] ALSA: sh: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 11/13] ALSA: sparc: " Arvind Yadav
2017-08-18 7:45 ` [PATCH 12/13] ALSA: spi: " Arvind Yadav
2017-08-19 9:04 ` [PATCH 00/13] constify alsa " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503042321-26758-6-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=daniel@zonque.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).