* [PATCH 08/12] ASoC: qcom: Remove useless function call
@ 2017-08-20 5:43 Peng Donglin
2017-08-21 8:08 ` [alsa-devel] " Banajit Goswami
0 siblings, 1 reply; 2+ messages in thread
From: Peng Donglin @ 2017-08-20 5:43 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, plai, bgoswami
Cc: alsa-devel, linux-kernel, Peng Donglin
The function platform_set_drvdata(pdev, data) copies the value of
the variable data to pdev->dev.driver_data,but when calling
snd_soc_register_card,the function dev_set_drvdata(card->dev, card)
will override it, so i think that the former copy operation is
useless and can be removed.
Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
---
sound/soc/qcom/apq8016_sbc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c
index d084d74..5292591 100644
--- a/sound/soc/qcom/apq8016_sbc.c
+++ b/sound/soc/qcom/apq8016_sbc.c
@@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev)
if (IS_ERR(data->spkr_iomux))
return PTR_ERR(data->spkr_iomux);
- platform_set_drvdata(pdev, data);
snd_soc_card_set_drvdata(card, data);
return devm_snd_soc_register_card(&pdev->dev, card);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function call
2017-08-20 5:43 [PATCH 08/12] ASoC: qcom: Remove useless function call Peng Donglin
@ 2017-08-21 8:08 ` Banajit Goswami
0 siblings, 0 replies; 2+ messages in thread
From: Banajit Goswami @ 2017-08-21 8:08 UTC (permalink / raw)
To: Peng Donglin
Cc: lgirdwood, broonie, perex, tiwai, plai, alsa-devel, linux-kernel
On Sun, Aug 20, 2017 at 01:43:57PM +0800, Peng Donglin wrote:
> The function platform_set_drvdata(pdev, data) copies the value of
> the variable data to pdev->dev.driver_data,but when calling
> snd_soc_register_card,the function dev_set_drvdata(card->dev, card)
> will override it, so i think that the former copy operation is
> useless and can be removed.
>
> Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
Acked-by: Banajit Goswami <bgoswami@codeaurora.org>
> ---
> sound/soc/qcom/apq8016_sbc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c
> index d084d74..5292591 100644
> --- a/sound/soc/qcom/apq8016_sbc.c
> +++ b/sound/soc/qcom/apq8016_sbc.c
> @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev)
> if (IS_ERR(data->spkr_iomux))
> return PTR_ERR(data->spkr_iomux);
>
> - platform_set_drvdata(pdev, data);
> snd_soc_card_set_drvdata(card, data);
>
> return devm_snd_soc_register_card(&pdev->dev, card);
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-21 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 5:43 [PATCH 08/12] ASoC: qcom: Remove useless function call Peng Donglin
2017-08-21 8:08 ` [alsa-devel] " Banajit Goswami
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).