From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Subject: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Date: Tue, 22 Aug 2017 21:51:46 -0400 Message-ID: <1503453106-5564-1-git-send-email-trini@konsulko.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yw0-f196.google.com (mail-yw0-f196.google.com [209.85.161.196]) by alsa0.perex.cz (Postfix) with ESMTP id 792C2266834 for ; Wed, 23 Aug 2017 03:51:39 +0200 (CEST) Received: by mail-yw0-f196.google.com with SMTP id y64so244886ywf.1 for ; Tue, 22 Aug 2017 18:51:39 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: linux-kernel@vger.kernel.org Cc: Oder Chiou , alsa-devel@alsa-project.org, Andy Shevchenko , Takashi Iwai , Liam Girdwood , Mark Brown , Bard Liao , Linus Torvalds List-Id: alsa-devel@alsa-project.org Not all devices with ACPI and this combination of sound devices will have the required information provided via ACPI. Reintroduce the I2C device ID to restore sound functionality on on the Chromebook 'Samus' model. Fixes: a36afb0ab648 ("ASoC: rt5677: Introduce proper table for ACPI enumeration") Cc: Bard Liao Cc: Oder Chiou Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: alsa-devel@alsa-project.org CC: linux-kernel@vger.kernel.org Cc: Andy Shevchenko Cc: Mark Brown Cc: Linus Torvalds Signed-off-by: Tom Rini --- This is a regression from v4.12 on my laptop (a Chromebook 'Samus' that's not running ChromeOS). My fault for getting out of the habit of trying -rc1 when it comes out and not spotting this sooner. I'm not 100% sure if this fix is correct for all cases as I'm only able to test my hardware here, and this does fix my laptop. --- sound/soc/codecs/rt5677.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index 36e530a36c82..6f629278d982 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5021,6 +5021,7 @@ static int rt5677_write(void *context, unsigned int reg, unsigned int val) static const struct i2c_device_id rt5677_i2c_id[] = { { "rt5677", RT5677 }, { "rt5676", RT5676 }, + { "RT5677CE:00", RT5677 }, { } }; MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id); -- 1.9.1