From: Daniel Baluta <daniel.baluta@nxp.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.de" <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v2 2/2] ASoC: cs43130: Fix unused compiler warnings for PM runtime
Date: Mon, 4 Sep 2017 14:31:03 +0000 [thread overview]
Message-ID: <1504535463.2899.9.camel@nxp.com> (raw)
In-Reply-To: <20170904135448.26314-2-tiwai@suse.de>
On Lu, 2017-09-04 at 15:54 +0200, Takashi Iwai wrote:
> Add __maybe_unused prefix for addressing the following warnings:
> sound/soc/codecs/cs43130.c:2615:12: warning: ‘cs43130_runtime_resume’ defined but not used [-Wunused-function]
> sound/soc/codecs/cs43130.c:2596:12: warning: ‘cs43130_runtime_suspend’ defined but not used [-Wunused-function]
>
Isn't it better to guard it with CONFIG_PM?
thanks,
Daniel.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-09-04 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 13:54 [PATCH v2 1/2] ASoC: cs43130: Fix possible Oops with invalid dev_id Takashi Iwai
2017-09-04 13:54 ` [PATCH v2 2/2] ASoC: cs43130: Fix unused compiler warnings for PM runtime Takashi Iwai
2017-09-04 14:31 ` Daniel Baluta [this message]
2017-09-04 14:34 ` Takashi Iwai
2017-09-04 14:44 ` Mark Brown
2017-09-04 15:46 ` Daniel Baluta
2017-09-04 14:49 ` Applied "ASoC: cs43130: Fix unused compiler warnings for PM runtime" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504535463.2899.9.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).