alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Tanu Kaskinen <tanuk@iki.fi>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [bug] Missing "front" definition for byt-max98090
Date: Thu, 07 Sep 2017 19:33:17 +0300	[thread overview]
Message-ID: <1504801997.2980.25.camel@iki.fi> (raw)
In-Reply-To: <s5hpob2havm.wl-tiwai@suse.de>

On Thu, 2017-09-07 at 15:54 +0200, Takashi Iwai wrote:
> On Thu, 07 Sep 2017 14:25:44 +0200,
> Tanu Kaskinen wrote:
> > 
> > PulseAudio 11 stopped using "hw:" as a fallback for analog stereo if
> > "front:" doesn't work. This caused a regression on "Toshiba Chromebook
> > 2 (Swanky)", because PulseAudio doesn't any more do automatic mixer
> > adjustments when plugging in headphones. Apparently on this machine
> > "hw:1,0" works fine as a substitute for "front:1,0", but we're not
> > going to revert the change in PulseAudio, so could someone add the
> > "front" definition for this machine in alsa-lib? Unfortunately I'm not
> > proficient enough in the alsa-lib configuration system to make a patch
> > myself.
> 
> Well, this is about the device that has no alsa-lib config.  So far,
> we assumed that 'front' is available only when defined for the card.
> But now PA mandates it...  Hmm.  I guess it's no big problem to add a
> fallback to hw for the front PCM.
> 
> The patch below should work for such a device.  It's a patch to
> alsa-lib source, but basically you can modify similarly the file
> /usr/share/alsa/pcm/front.conf directly, too.
> 
> If it's confirmed to work, I'll merge the patch.
> 
> Maybe we can release alsa-lib 1.1.5 along with 4.13 kernel, so a
> quicker reply would be appreciated.

The reporter said[1] that your patch works fine.

I have a concern, though: what about those cases where hw:x,0 is not an
analog stereo device? The reason why PulseAudio was changed is that
with the Intel HDMI LPE driver PulseAudio thought that the card had an
analog stereo device, when in reality it only had HDMI. Doesn't your
patch reintroduce this problem?

[1] https://bugs.freedesktop.org/show_bug.cgi?id=102560#c6

-- 
Tanu

https://www.patreon.com/tanuk

  reply	other threads:[~2017-09-07 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 12:25 [bug] Missing "front" definition for byt-max98090 Tanu Kaskinen
2017-09-07 13:54 ` Takashi Iwai
2017-09-07 16:33   ` Tanu Kaskinen [this message]
2017-09-07 17:13     ` Takashi Iwai
2017-09-08 11:30       ` Tanu Kaskinen
2017-09-08 12:16         ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504801997.2980.25.camel@iki.fi \
    --to=tanuk@iki.fi \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).