* [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
@ 2017-09-12 19:54 Chintan Patel
2017-09-12 20:47 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Chintan Patel @ 2017-09-12 19:54 UTC (permalink / raw)
To: alsa-devel; +Cc: Chintan Patel
In case of failure in loading customize topology firmware, dfw_sst.bin
gets loaded. However, current log provides this message as error even
after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..14dafa9f5b35 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev);
if (ret < 0) {
- dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+ dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
skl->tplg_name, ret);
ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
if (ret < 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
2017-09-12 19:54 [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
@ 2017-09-12 20:47 ` Takashi Iwai
2017-09-12 21:47 ` Patel, Chintan M
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2017-09-12 20:47 UTC (permalink / raw)
To: Chintan Patel; +Cc: alsa-devel
On Tue, 12 Sep 2017 21:54:58 +0200,
Chintan Patel wrote:
>
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
>
> Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this
is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side?
In that case, KERN_WARN would be OK.
thanks,
Takashi
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> sound/soc/intel/skylake/skl-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..14dafa9f5b35 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
>
> ret = request_firmware(&fw, skl->tplg_name, bus->dev);
> if (ret < 0) {
> - dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> + dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
> skl->tplg_name, ret);
> ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
> if (ret < 0) {
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
2017-09-12 20:47 ` Takashi Iwai
@ 2017-09-12 21:47 ` Patel, Chintan M
2017-09-14 18:53 ` Patel, Chintan M
0 siblings, 1 reply; 6+ messages in thread
From: Patel, Chintan M @ 2017-09-12 21:47 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel@alsa-project.org
Hmm ... you are right. KERN_INFO make sense.
Will re-submit it.
-----Original Message-----
From: Takashi Iwai [mailto:tiwai@suse.de]
Sent: Tuesday, September 12, 2017 1:47 PM
To: Patel, Chintan M <chintan.m.patel@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
On Tue, 12 Sep 2017 21:54:58 +0200,
Chintan Patel wrote:
>
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
>
> Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side?
In that case, KERN_WARN would be OK.
thanks,
Takashi
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> sound/soc/intel/skylake/skl-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl-topology.c
> b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..14dafa9f5b35 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform
> *platform, struct hdac_ext_bus *ebus)
>
> ret = request_firmware(&fw, skl->tplg_name, bus->dev);
> if (ret < 0) {
> - dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> + dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to
> +dfw_sst.bin",
> skl->tplg_name, ret);
> ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
> if (ret < 0) {
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
@ 2017-09-12 21:59 Chintan Patel
2017-10-25 12:03 ` Applied "ASoC: Intel: Skylake: Decrease loglevel for topology loading" to the asoc tree Mark Brown
0 siblings, 1 reply; 6+ messages in thread
From: Chintan Patel @ 2017-09-12 21:59 UTC (permalink / raw)
To: alsa-devel; +Cc: Chintan Patel
In case of failure in loading customize topology firmware, dfw_sst.bin
gets loaded. However, current log provides this message as error even
after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..12f383fd7c39 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev);
if (ret < 0) {
- dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+ dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
skl->tplg_name, ret);
ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
if (ret < 0) {
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
2017-09-12 21:47 ` Patel, Chintan M
@ 2017-09-14 18:53 ` Patel, Chintan M
0 siblings, 0 replies; 6+ messages in thread
From: Patel, Chintan M @ 2017-09-14 18:53 UTC (permalink / raw)
To: 'Takashi Iwai'; +Cc: 'alsa-devel@alsa-project.org'
Please ignore this patch.
I have submitted another patch.
Sorry for noise, was submitting first time here
-----Original Message-----
From: Patel, Chintan M
Sent: Tuesday, September 12, 2017 2:47 PM
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: RE: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
Hmm ... you are right. KERN_INFO make sense.
Will re-submit it.
-----Original Message-----
From: Takashi Iwai [mailto:tiwai@suse.de]
Sent: Tuesday, September 12, 2017 1:47 PM
To: Patel, Chintan M <chintan.m.patel@intel.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
On Tue, 12 Sep 2017 21:54:58 +0200,
Chintan Patel wrote:
>
> In case of failure in loading customize topology firmware, dfw_sst.bin
> gets loaded. However, current log provides this message as error even
> after successfully falling back to default topology "dfw_sst.bin".
>
> Hence to convey proper message, changing log level and message.
Is KERN_WARN the right level? I feel KERN_INFO suffices, since this is no error but the right behavior, after all.
Or is this an unexpected scenario that should be fixed in user side?
In that case, KERN_WARN would be OK.
thanks,
Takashi
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> sound/soc/intel/skylake/skl-topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/skl-topology.c
> b/sound/soc/intel/skylake/skl-topology.c
> index 22f768ca3c73..14dafa9f5b35 100644
> --- a/sound/soc/intel/skylake/skl-topology.c
> +++ b/sound/soc/intel/skylake/skl-topology.c
> @@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform
> *platform, struct hdac_ext_bus *ebus)
>
> ret = request_firmware(&fw, skl->tplg_name, bus->dev);
> if (ret < 0) {
> - dev_err(bus->dev, "tplg fw %s load failed with %d\n",
> + dev_warn(bus->dev, "tplg fw %s load failed with %d, falling back to
> +dfw_sst.bin",
> skl->tplg_name, ret);
> ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
> if (ret < 0) {
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: Intel: Skylake: Decrease loglevel for topology loading" to the asoc tree
2017-09-12 21:59 [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
@ 2017-10-25 12:03 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2017-10-25 12:03 UTC (permalink / raw)
To: Chintan Patel; +Cc: alsa-devel, Mark Brown
The patch
ASoC: Intel: Skylake: Decrease loglevel for topology loading
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 19de7179974ff6cf43e8a893028d3aef06cdb0bf Mon Sep 17 00:00:00 2001
From: Chintan Patel <chintan.m.patel@intel.com>
Date: Thu, 12 Oct 2017 09:44:37 -0700
Subject: [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading
In case of failure in loading customize topology firmware, dfw_sst.bin
gets loaded. However, current log provides this message as error even
after successfully falling back to default topology "dfw_sst.bin".
Hence to convey proper message, changing log level and message.
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/skylake/skl-topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index ff4f53cdc0a1..1200b7c6af56 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -3405,7 +3405,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
ret = request_firmware(&fw, skl->tplg_name, bus->dev);
if (ret < 0) {
- dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+ dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
skl->tplg_name, ret);
ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
if (ret < 0) {
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-25 12:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 21:59 [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
2017-10-25 12:03 ` Applied "ASoC: Intel: Skylake: Decrease loglevel for topology loading" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2017-09-12 19:54 [PATCH] ASoC: Intel: Skylake: Decrease loglevel for topology loading Chintan Patel
2017-09-12 20:47 ` Takashi Iwai
2017-09-12 21:47 ` Patel, Chintan M
2017-09-14 18:53 ` Patel, Chintan M
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).