From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
broonie@kernel.org, vinod.koul@intel.com
Subject: Re: [PATCH 4/5] ASoC: Intel: bytcr_rt5651: filter codec name
Date: Mon, 18 Sep 2017 10:13:05 +0300 [thread overview]
Message-ID: <1505718785.25945.267.camel@linux.intel.com> (raw)
In-Reply-To: <20170908174356.23788-5-pierre-louis.bossart@linux.intel.com>
On Fri, 2017-09-08 at 12:43 -0500, Pierre-Louis Bossart wrote:
> Use same fix as other codecs to work around BIOS/ACPI issues
>
>
> {
> int ret_val = 0;
> + struct sst_acpi_mach *mach;
> + const char *i2c_name = NULL;
> + int i;
> + int dai_index;
> struct byt_rt5651_private *priv;
I would rather put variables in reversed xmas tree order or close to it.
+
> + /* fixup codec name based on HID */
> + i2c_name = sst_acpi_find_name_from_hid(mach->id);
> + if (i2c_name != NULL) {
if (i2c_name) { ?
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-09-18 7:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 17:43 [PATCH 0/5] BYT/CHT-Realtek remaining fixes Pierre-Louis Bossart
2017-09-08 17:43 ` [PATCH 1/5] ASoC: Intel: boards: use devm_clk_get() unconditionally Pierre-Louis Bossart
2017-09-19 13:46 ` Applied "ASoC: Intel: boards: use devm_clk_get() unconditionally" to the asoc tree Mark Brown
2017-09-08 17:43 ` [PATCH 2/5] ASoC: Intel: bytcr-rt5651: fix capture routes Pierre-Louis Bossart
2017-09-08 17:43 ` [PATCH 3/5] ASoC: Intel: bytcr_rt5651: add MCLK support and fix quirks Pierre-Louis Bossart
2017-09-18 7:10 ` Andy Shevchenko
2017-09-18 17:20 ` Pierre-Louis Bossart
2017-09-08 17:43 ` [PATCH 4/5] ASoC: Intel: bytcr_rt5651: filter codec name Pierre-Louis Bossart
2017-09-18 7:13 ` Andy Shevchenko [this message]
2017-09-18 17:24 ` Pierre-Louis Bossart
2017-09-08 17:43 ` [PATCH 5/5] ASoC: Intel: bytcr_rt5640: simplify MCLK quirk tests Pierre-Louis Bossart
2017-09-18 3:34 ` [PATCH 0/5] BYT/CHT-Realtek remaining fixes Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505718785.25945.267.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).