From: yesanishhere@gmail.com
To: ckeepax@opensource.cirrus.com, broonie@kernel.org,
lgirdwood@gmail.com, perex@perex.cz, alsa-devel@alsa-project.org,
tiwai@suse.com
Cc: anish kumar <yesanishhere@gmail.com>
Subject: [Resend] [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm
Date: Wed, 20 Sep 2017 01:28:33 -0700 [thread overview]
Message-ID: <1505896116-43310-2-git-send-email-yesanishhere@gmail.com> (raw)
In-Reply-To: <1505896116-43310-1-git-send-email-yesanishhere@gmail.com>
From: anish kumar <yesanishhere@gmail.com>
w_param_text[count] is freed in the wrong error path.
Fix it by shifting the outfree_w_param label.
Signed-off-by: anish kumar <yesanishhere@gmail.com>
---
sound/soc/soc-dapm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index dcef67a..f51f613 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3907,9 +3907,9 @@ int snd_soc_dapm_new_pcm(struct snd_soc_card *card,
devm_kfree(card->dev, (void *)private_value);
outfree_link_name:
devm_kfree(card->dev, link_name);
-outfree_w_param:
for (count = 0 ; count < num_params; count++)
devm_kfree(card->dev, (void *)w_param_text[count]);
+outfree_w_param:
devm_kfree(card->dev, w_param_text);
return ret;
--
2.5.4 (Apple Git-61)
next prev parent reply other threads:[~2017-09-20 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 8:28 [Resend] [PATCH 0/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20 8:28 ` yesanishhere [this message]
2017-09-20 11:02 ` [Resend] [PATCH 1/4] ASoC: dapm: fix error path in snd_soc_dapm_new_pcm Charles Keepax
2017-09-20 11:42 ` Applied "ASoC: dapm: fix error path in snd_soc_dapm_new_pcm" to the asoc tree Mark Brown
2017-09-20 8:28 ` [Resend] [PATCH 2/4] ASoC: dapm: Refactor the code in snd_soc_dapm_new_pcm yesanishhere
2017-09-20 11:02 ` Charles Keepax
2017-09-20 8:28 ` [Resend] [PATCH 3/4] ASoC: dapm: Avoid creating kcontrol for params yesanishhere
2017-09-20 11:05 ` Charles Keepax
2017-09-20 8:28 ` [Resend] [PATCH 4/4] ASoC: dapm: Remove the redundant check yesanishhere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1505896116-43310-2-git-send-email-yesanishhere@gmail.com \
--to=yesanishhere@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).