alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Chintan Patel <chintan.m.patel@intel.com>
Cc: vinod.koul@intel.com, Chintan Patel <chintan.m.patel@intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Jeeja KP <jeeja.kp@intel.com>,
	"guneshwor.o.singh@intel.com" <guneshwor.o.singh@intel.com>,
	Shreyas NC <shreyas.nc@intel.com>,
	Takashi Sakamoto <takashi.sakamoto@miraclelinux.com>,
	Ramesh Babu <ramesh.babu@intel.com>,
	Dharageswari R <dharageswari.r@intel.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading
Date: Thu, 12 Oct 2017 09:44:37 -0700	[thread overview]
Message-ID: <1507826678-25509-1-git-send-email-chintan.m.patel@intel.com> (raw)

In case of failure in loading customize topology firmware, dfw_sst.bin
gets loaded. However, current log provides this message as error even
after successfully falling back to default topology "dfw_sst.bin".

Hence to convey proper message, changing log level and message.

Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
Changes in v2:
Addressing review comments from Takashi Iwai by changing
loglevel as info

sound/soc/intel/skylake/skl-topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index 22f768ca3c73..12f383fd7c39 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -3404,7 +3404,7 @@ int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
 
 	ret = request_firmware(&fw, skl->tplg_name, bus->dev);
 	if (ret < 0) {
-		dev_err(bus->dev, "tplg fw %s load failed with %d\n",
+		dev_info(bus->dev, "tplg fw %s load failed with %d, falling back to dfw_sst.bin",
 				skl->tplg_name, ret);
 		ret = request_firmware(&fw, "dfw_sst.bin", bus->dev);
 		if (ret < 0) {
-- 
1.9.1

             reply	other threads:[~2017-10-12 16:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 16:44 Chintan Patel [this message]
2017-10-16  6:05 ` [PATCH v2] ASoC: Intel: Skylake: Decrease loglevel for topology loading Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507826678-25509-1-git-send-email-chintan.m.patel@intel.com \
    --to=chintan.m.patel@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=dharageswari.r@intel.com \
    --cc=guneshwor.o.singh@intel.com \
    --cc=jeeja.kp@intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ramesh.babu@intel.com \
    --cc=shreyas.nc@intel.com \
    --cc=takashi.sakamoto@miraclelinux.com \
    --cc=tiwai@suse.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).