From: Lucas Stach <l.stach@pengutronix.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>,
patchwork-lst@pengutronix.de, kernel@pengutronix.de,
peter.seiderer.ext@zeiss.com, dmaengine@vger.kernel.org,
LW@KARO-electronics.de
Subject: Re: [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths
Date: Fri, 13 Oct 2017 16:50:01 +0200 [thread overview]
Message-ID: <1507906201.5860.9.camel@pengutronix.de> (raw)
In-Reply-To: <20171013143901.t5wtxesho2wip4d7@sirena.co.uk>
Am Freitag, den 13.10.2017, 15:39 +0100 schrieb Mark Brown:
> On Fri, Oct 13, 2017 at 01:35:43PM +0200, Lucas Stach wrote:
> > Am Freitag, den 13.10.2017, 12:25 +0100 schrieb Mark Brown:
> > > On Fri, Oct 13, 2017 at 12:43:46PM +0200, Lucas Stach wrote:
> > > > The commit [1] which changed imx-pcm-dma to derive the pcm_config from the
> > > > attached dmaengine introduced a regression on the supported sample formats,
> > > > as imx-sdma doesn't properly advertise all the supported slave bus widths.
> > > How did this work previously - shouldn't we have failed to use the
> > > unadvertised bus widths? I'd expect the framework to be providing error
> > > checking for the clients here.
> > No, if the sound PCM implementation explicitly provides a pcm_config
> > with the hw.formats set to 0, the core only looks at the DAI supported
> > formats. Now that we derive the pcm_config from the dmaengine
>
> I'm not talking about the sound side here...
>
> > hw.formats gets filled with formats supported by the dmaengine, which
> > is then used as an additional constraint by the core.
>
> ...I'm talking about the constraints supported on the DMA side. I would
> not expect the DMA side to be accepting things it said it didn't support.
AFAIR the caps for the supported slave bus width were introduced later
than other caps and not all drivers did implement them properly, so
validation at the core level at this time would probably have broken a
lot of existing users.
That said the dmaengine core warns since kernel 4.0 if a driver doesn't
set those caps, so it's probably fine if we cook up a patch to do the
validation now.
Regards,
Lucas
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-10-13 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 10:43 [PATCH] dmaengine: imx-sdma: advertise all supported slave bus widths Lucas Stach
2017-10-13 11:23 ` Lothar Waßmann
2017-10-13 11:25 ` Mark Brown
2017-10-13 11:35 ` Lucas Stach
2017-10-13 14:39 ` Mark Brown
2017-10-13 14:50 ` Lucas Stach [this message]
2017-10-13 17:13 ` Mark Brown
2017-10-16 6:28 ` Vinod Koul
2017-10-16 9:19 ` Mark Brown
2017-10-16 6:51 ` Vinod Koul
2017-10-16 7:26 ` Lucas Stach
2017-10-31 12:13 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507906201.5860.9.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=LW@KARO-electronics.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
--cc=peter.seiderer.ext@zeiss.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).