From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com, broonie@kernel.org,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH v2 0/9] Baytrail-Cherrytrail updates
Date: Fri, 13 Oct 2017 19:23:24 +0300 [thread overview]
Message-ID: <1507911804.16112.455.camel@linux.intel.com> (raw)
In-Reply-To: <20171012233805.30055-1-pierre-louis.bossart@linux.intel.com>
On Thu, 2017-10-12 at 18:37 -0500, Pierre-Louis Bossart wrote:
> As discussed on the alsa-devel mailing list, here is a set of patches
> to fix
>
> 1. previous feedback on bytcht_rt5651 - no new functionality beyond
> what was already reviewed
> 2. cosmetic issues (variables in reverse xmas tree order, etc)
> 3. unnecessary clock tests
> 4. addition of a helper to remove duplicate code across machine
> drivers
>
> The last two patches were not included in the first pass,
> they correct an off-by-one issue which has no functional impact
> and remove the hard-codec compressed dailinks which don't currently
> work with the mainline code+publicly available firmware.
>
Patch 6 can be folded into 5, but it's up to you. Either choice:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Pierre-Louis Bossart (9):
> ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups
> ASoC: Intel: bytcr_rt5640: cosmetic fixes
> ASoC: Intel: cht_bsw_rt5645: cosmetic fixes
> ASoC: Intel: bytcht_da7213: cosmetic fixes
> ASoC: Intel: bytcht_es8316: remove useless code
> ASoC: Add helper to find codec_dai from dai_name
> ASoC: Intel: boards: use helper to get codec_dai
> ASoC: Intel: boards: fix off-by-one dailink id
> ASoC: Intel: boards: remove hard-coded compressed dailinks
>
> include/sound/soc.h | 14 ++
> sound/soc/intel/boards/bxt_da7219_max98357a.c | 16 +-
> sound/soc/intel/boards/bytcht_da7213.c | 17 +-
> sound/soc/intel/boards/bytcht_es8316.c | 25 +--
> sound/soc/intel/boards/bytcht_nocodec.c | 10 +-
> sound/soc/intel/boards/bytcr_rt5640.c | 105 ++++-------
> sound/soc/intel/boards/bytcr_rt5651.c | 236
> +++++++++++++++++++++---
> sound/soc/intel/boards/cht_bsw_max98090_ti.c | 24 +--
> sound/soc/intel/boards/cht_bsw_rt5645.c | 103 ++++-------
> sound/soc/intel/boards/cht_bsw_rt5672.c | 24 +--
> sound/soc/intel/boards/skl_nau88l25_max98357a.c | 16 +-
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 16 +-
> 12 files changed, 318 insertions(+), 288 deletions(-)
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-10-13 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:37 [PATCH v2 0/9] Baytrail-Cherrytrail updates Pierre-Louis Bossart
2017-10-12 23:37 ` [PATCH v2 1/9] ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups Pierre-Louis Bossart
2017-10-18 11:31 ` Applied "ASoC: Intel: bytcr_rt5651: add MCLK, quirks and cleanups" to the asoc tree Mark Brown
2017-10-12 23:37 ` [PATCH v2 2/9] ASoC: Intel: bytcr_rt5640: cosmetic fixes Pierre-Louis Bossart
2017-10-12 23:37 ` [PATCH v2 3/9] ASoC: Intel: cht_bsw_rt5645: " Pierre-Louis Bossart
2017-10-12 23:38 ` [PATCH v2 4/9] ASoC: Intel: bytcht_da7213: " Pierre-Louis Bossart
2017-10-12 23:38 ` [PATCH v2 5/9] ASoC: Intel: bytcht_es8316: remove useless code Pierre-Louis Bossart
2017-10-18 11:31 ` Applied "ASoC: Intel: bytcht_es8316: remove useless code" to the asoc tree Mark Brown
2017-10-12 23:38 ` [PATCH v2 6/9] ASoC: Add helper to find codec_dai from dai_name Pierre-Louis Bossart
2017-10-18 11:27 ` Applied "ASoC: Add helper to find codec_dai from dai_name" to the asoc tree Mark Brown
2017-10-12 23:38 ` [PATCH v2 7/9] ASoC: Intel: boards: use helper to get codec_dai Pierre-Louis Bossart
2017-10-18 11:31 ` Applied "ASoC: Intel: boards: use helper to get codec_dai" to the asoc tree Mark Brown
2017-10-12 23:38 ` [PATCH v2 8/9] ASoC: Intel: boards: fix off-by-one dailink id Pierre-Louis Bossart
2017-10-18 11:31 ` Applied "ASoC: Intel: boards: fix off-by-one dailink id" to the asoc tree Mark Brown
2017-10-12 23:38 ` [PATCH v2 9/9] ASoC: Intel: boards: remove hard-coded compressed dailinks Pierre-Louis Bossart
2017-10-13 15:49 ` [PATCH v2 0/9] Baytrail-Cherrytrail updates Liam Girdwood
2017-10-13 16:23 ` Andy Shevchenko [this message]
2017-10-13 16:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507911804.16112.455.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).