From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com, broonie@kernel.org,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH 4/8] ASoC: Intel: move all ACPI match tables to common module
Date: Fri, 13 Oct 2017 19:38:46 +0300 [thread overview]
Message-ID: <1507912726.16112.466.camel@linux.intel.com> (raw)
In-Reply-To: <20171012234945.30318-5-pierre-louis.bossart@linux.intel.com>
On Thu, 2017-10-12 at 18:49 -0500, Pierre-Louis Bossart wrote:
> First step of cleaning, move all tables to soc-acpi-intel-match
> module.
> The tables remain in separate files per platform to keep them
> manageable. Skylake+ platforms are still handled elsewhere since
> there is no conflict with SOF for now, but this will have to be
> handled at a later point.
> +static int is_byt(void)
> +{
> + bool status = false;
> + static const struct x86_cpu_id cpu_ids[] = {
> + { X86_VENDOR_INTEL, 6, 55 }, /* Valleyview, Bay Trail
> */
> + {}
> + };
> + if (x86_match_cpu(cpu_ids))
> + status = true;
> + return status;
> +}
I wish it would be cleaned up at some point...
P.S. Yes, I have commented on this earlier.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-10-13 16:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:49 [PATCH 0/8] ASoC: Prepare Sound Open Firmware (SOF) driver integration Pierre-Louis Bossart
2017-10-12 23:49 ` [PATCH 1/8] ASoC: move ACPI common code out of Intel/sst tree Pierre-Louis Bossart
2017-10-12 23:49 ` [PATCH 2/8] ASoC: Intel: common: use c99 syntax for ACPI/machine tables Pierre-Louis Bossart
2017-10-12 23:49 ` [PATCH 3/8] ASoC: ACPI: add new fields for SOF support Pierre-Louis Bossart
2017-10-13 16:35 ` Andy Shevchenko
2017-10-13 17:17 ` Pierre-Louis Bossart
2017-10-21 10:30 ` Applied "ASoC: ACPI: add new fields for SOF support" to the asoc tree Mark Brown
2017-10-12 23:49 ` [PATCH 4/8] ASoC: Intel: move all ACPI match tables to common module Pierre-Louis Bossart
2017-10-13 16:38 ` Andy Shevchenko [this message]
2017-10-13 17:21 ` Pierre-Louis Bossart
2017-10-21 10:29 ` Applied "ASoC: Intel: move all ACPI match tables to common module" to the asoc tree Mark Brown
2017-10-12 23:49 ` [PATCH 5/8] ASoC: Intel: add SOF firmare/topology file information Pierre-Louis Bossart
2017-10-21 10:29 ` Applied "ASoC: Intel: add SOF firmare/topology file information" to the asoc tree Mark Brown
2017-10-12 23:49 ` [PATCH 6/8] ASoC: Intel: move machine drivers to dedicated KConfig Pierre-Louis Bossart
2017-10-12 23:49 ` [PATCH 7/8] ASoC: Intel: reorder boards Kconfig by chronological order Pierre-Louis Bossart
2017-10-12 23:49 ` [PATCH 8/8] ASoC: Intel: clarify Kconfig dependencies Pierre-Louis Bossart
2017-10-19 21:18 ` [PATCH 0/8] ASoC: Prepare Sound Open Firmware (SOF) driver integration Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507912726.16112.466.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).