From: "Ughreja, Rakesh A" <rakesh.a.ughreja@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, vinod.koul@intel.com,
Rakesh Ughreja <rakesh.a.ughreja@intel.com>
Subject: [PATCH v2] ALSA: hda: Abort capability probe on invalid capability
Date: Thu, 19 Oct 2017 05:15:25 +0530 [thread overview]
Message-ID: <1508370325-3118-1-git-send-email-rakesh.a.ughreja@intel.com> (raw)
From: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
Due to bugs in BIOS it's possible that the HDA capability link
list is not constructed properly. This may lead to driver going
into unknown state. So whenever driver discovers unknown HDA
capability, log it as error and stop traversing the link list
further.
Signed-off-by: Rakesh Ughreja <rakesh.a.ughreja@intel.com>
---
sound/hda/hdac_controller.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
index 978dc18..8f7d0d9 100644
--- a/sound/hda/hdac_controller.c
+++ b/sound/hda/hdac_controller.c
@@ -314,7 +314,8 @@ int snd_hdac_bus_parse_capabilities(struct hdac_bus *bus)
break;
default:
- dev_dbg(bus->dev, "Unknown capability %d\n", cur_cap);
+ dev_err(bus->dev, "Unknown capability %d\n", cur_cap);
+ cur_cap = 0;
break;
}
--
2.7.4
next reply other threads:[~2017-10-18 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 23:45 Ughreja, Rakesh A [this message]
2017-10-18 16:26 ` [PATCH v2] ALSA: hda: Abort capability probe on invalid capability Vinod Koul
2017-10-18 16:52 ` Ughreja, Rakesh A
2017-10-19 7:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508370325-3118-1-git-send-email-rakesh.a.ughreja@intel.com \
--to=rakesh.a.ughreja@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).