From: Naveen Manohar <naveen.m@intel.com>
To: alsa-devel@alsa-project.org
Cc: vinod.koul@intel.com, liam.r.girdwood@linux.intel.com,
tiwai@suse.de, broonie@kernel.org, naveen.m@intel.com,
pierre-louis.bossart@intel.com
Subject: [PATCH 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata
Date: Thu, 9 Nov 2017 19:34:35 +0530 [thread overview]
Message-ID: <1510236276-3416-2-git-send-email-naveen.m@intel.com> (raw)
In-Reply-To: <1510236276-3416-1-git-send-email-naveen.m@intel.com>
User-space expects 4ch DMIC data and uses channel-map in ucm to
figure-out the desired channel to use. Hence removing driver change
to allow choosing channels using pdata.
Signed-off-by: Naveen Manohar <naveen.m@intel.com>
---
sound/soc/intel/boards/kbl_rt5663_max98927.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/sound/soc/intel/boards/kbl_rt5663_max98927.c b/sound/soc/intel/boards/kbl_rt5663_max98927.c
index 7f76074..661f164 100644
--- a/sound/soc/intel/boards/kbl_rt5663_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_max98927.c
@@ -390,26 +390,6 @@ static int kabylake_dmic_fixup(struct snd_soc_pcm_runtime *rtd,
return 0;
}
-static unsigned int channels_dmic[] = {
- 2, 4,
-};
-
-static struct snd_pcm_hw_constraint_list constraints_dmic_channels = {
- .count = ARRAY_SIZE(channels_dmic),
- .list = channels_dmic,
- .mask = 0,
-};
-
-static const unsigned int dmic_2ch[] = {
- 2,
-};
-
-static const struct snd_pcm_hw_constraint_list constraints_dmic_2ch = {
- .count = ARRAY_SIZE(dmic_2ch),
- .list = dmic_2ch,
- .mask = 0,
-};
-
static int kabylake_dmic_startup(struct snd_pcm_substream *substream)
{
struct snd_pcm_runtime *runtime = substream->runtime;
@@ -838,7 +818,6 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
static int kabylake_audio_probe(struct platform_device *pdev)
{
struct kbl_rt5663_private *ctx;
- struct skl_machine_pdata *pdata;
ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_ATOMIC);
if (!ctx)
@@ -852,11 +831,6 @@ static int kabylake_audio_probe(struct platform_device *pdev)
kabylake_audio_card->dev = &pdev->dev;
snd_soc_card_set_drvdata(kabylake_audio_card, ctx);
- pdata = dev_get_drvdata(&pdev->dev);
- if (pdata)
- dmic_constraints = pdata->dmic_num == 2 ?
- &constraints_dmic_2ch : &constraints_dmic_channels;
-
return devm_snd_soc_register_card(&pdev->dev, kabylake_audio_card);
}
--
1.9.1
next prev parent reply other threads:[~2017-11-09 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 14:04 [PATCH 0/2] ASoC: Intel: kbl: update dmic fixup params Naveen Manohar
2017-11-09 14:04 ` Naveen Manohar [this message]
2017-11-16 11:48 ` [PATCH 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata Mark Brown
2017-11-09 14:04 ` [PATCH 2/2] ASoC: Intel: kbl: update dmic fixup params Naveen Manohar
2017-11-15 4:55 ` [PATCH 0/2] " Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2021-02-18 12:31 [PATCH 0/2] dmic fix to allow userspace to choose ch count vamshi.krishna.gopal
2021-02-18 12:31 ` [PATCH 1/2] ASoC: Intel: kbl: Remove option of choosing CH count based on pdata vamshi.krishna.gopal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510236276-3416-2-git-send-email-naveen.m@intel.com \
--to=naveen.m@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox