From: Daniel Baluta <daniel.baluta@nxp.com>
To: "fischerc@swissphone.de" <fischerc@swissphone.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"tiwai@suse.com" <tiwai@suse.com>
Subject: Re: [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias
Date: Wed, 10 Jan 2018 14:31:13 +0000 [thread overview]
Message-ID: <1515594672.12654.101.camel@nxp.com> (raw)
In-Reply-To: <DD64F087E8F0B540A1C9216D6716FFBDF9946A6E@defrsexc01.swissphone.de>
On Mi, 2018-01-10 at 14:26 +0000, Fischer, Christian wrote:
> Hello Fabio,
>
> is it now ok?
> I'm not working with linux-git, so my patch is created by myself.
>
> Regards,
> Christian
>
> Signed-off-by: Christian Fischer <fischerc@swissphone.de>
Hi Christian,
This doesn't look good to me. How are creating/sending the patches?
You should update the commit message to include your Signed-off-by tag
and then resend the entire patch.
thanks,
Daniel.
>
> --- sound/soc/codecs/sgtl5000.c
> +++ sound/soc/codecs/sgtl5000.c
> @@ -260,6 +260,9 @@ static const struct snd_soc_dapm_widget
>
> SND_SOC_DAPM_PRE("VAG_POWER_PRE", power_vag_event),
> SND_SOC_DAPM_POST("VAG_POWER_POST", power_vag_event),
> +
> + SND_SOC_DAPM_PRE("MIC_BIAS_PRE", mic_bias_event),
> + SND_SOC_DAPM_POST("MIC_BIAS_POST", mic_bias_event),
> };
>
> /* routes for sgtl5000 */
>
> -----Ursprüngliche Nachricht-----
> Von: Fabio Estevam [mailto:festevam@gmail.com]
> Gesendet: Mittwoch, 10. Januar 2018 13:42
> An: Fischer, Christian <fischerc@swissphone.de>
> Cc: alsa-devel@alsa-project.org; Takashi Iwai <tiwai@suse.com>; Mark Brown <broonie@kernel.org>; Liam Girdwood <lgirdwood@gmail.com>
> Betreff: Re: [alsa-devel] [PATCH] ASoC: sgtl5000: Fix powerup/down of micbias
>
> Hi Christian,
>
> On Wed, Jan 10, 2018 at 8:07 AM, Fischer, Christian <fischerc@swissphone.de> wrote:
> >
> > The bias-bias-voltage should powered up/down automatically.
> > Added missing DAPM_PRE and DAPM_POST widgets to fire up the mic_bias_event function.
> Thanks for submitting the patch.
>
> You missed your Signed-off-by tag.
>
> Please resend it.
>
> Thanks
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmailman.alsa-project.org%2Fmailman%2Flistinfo%2Falsa-devel&data=02%7C01%7Cdaniel.baluta%40nxp.com%7C4a771694af314fa7d73008d558362a37
> %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636511912029282885&sdata=Zo42ZJxIxp54YyYLVsFrrRWkDt%2FqByR6uqr8U6pX3iY%3D&reserved=0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-01-10 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 14:26 [PATCH v2] ASoC: sgtl5000: Fix powerup/down of micbias Fischer, Christian
2018-01-10 14:31 ` Daniel Baluta [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-10 15:53 Fischer, Christian
2018-01-10 17:57 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515594672.12654.101.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fischerc@swissphone.de \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox