alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@nxp.com>
To: "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"wakasugi.jb@om.asahi-kasei.co.jp"
	<wakasugi.jb@om.asahi-kasei.co.jp>,
	"mihai.serban@nxp.com" <mihai.serban@nxp.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	Cosmin Samoila <cosmin.samoila@nxp.com>,
	"mihai.serban@gmail.com" <mihai.serban@gmail.com>
Subject: Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver
Date: Thu, 1 Feb 2018 09:05:55 +0000	[thread overview]
Message-ID: <1517475954.8615.18.camel@nxp.com> (raw)
In-Reply-To: <CAHp75Vdd58U1y-LOQGg=rePOWf1LeQsZxn2ykzBhXL013ztW3Q@mail.gmail.com>

Hi Fabio, Andy,

Thanks a lot for your comments. I will address them and send v2.

Few comments inline.

On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote:
> On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta <daniel.baluta@nxp.com> wrote:
> > 
> > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC
> > for digital audio systems.
> > 
> > Signed-off-by: Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>
> > Signed-off-by: Mihai Serban <mihai.serban@nxp.com>
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> 4 authors of the code?!

The code has a very long history. I will add under each SoB the specific
contribution.

Mihai got the code from Junichi and reworked it for 4.9. Then Shengjiu and
me added various features and cleanups.

According to DCO [1] all SoB are valid and required.


> > +MODULE_AUTHOR("Junichi Wakasugi <wakasugi.jb@om.asahi-kasei.co.jp>");
> > +MODULE_AUTHOR("Mihai Serban <mihai.serban@nxp.com>");
> 4 SoBs, 2 Authors. Please, fix accordingly.

Here I would prefer to list Junichi and Mihai because they were the main contributors.
Any other suggestion?

thanks,
Daniel.

[1] [1] https://developercertificate.org/
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2018-02-01  9:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 12:57 [PATCH] ASoC: codecs: Add support for AK5558 ADC driver Daniel Baluta
2018-01-31 16:12 ` Andy Shevchenko
2018-02-01  9:05   ` Daniel Baluta [this message]
2018-02-01 13:20     ` Andy Shevchenko
2018-02-01 13:48       ` Mark Brown
     [not found]         ` <20180201134840.GA10785-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-01 14:46           ` Andy Shevchenko
2018-02-02 15:06             ` Mark Brown
2018-02-02 16:09               ` Andy Shevchenko
     [not found] ` <1517403459-6668-1-git-send-email-daniel.baluta-3arQi8VN3Tc@public.gmane.org>
2018-01-31 16:20   ` Fabio Estevam
2018-01-31 16:56     ` Andy Shevchenko
     [not found]     ` <CAOMZO5BToV0OKEc_f8M1=zSL-X=qSXnokFyEfEEX2tGTUO=a-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-31 17:08       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517475954.8615.18.camel@nxp.com \
    --to=daniel.baluta@nxp.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=cosmin.samoila@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mihai.serban@gmail.com \
    --cc=mihai.serban@nxp.com \
    --cc=shengjiu.wang@nxp.com \
    --cc=wakasugi.jb@om.asahi-kasei.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).