From: <twischer@de.adit-jv.com>
To: tiwai@suse.de
Cc: Timo Wischer <twischer@de.adit-jv.com>, alsa-devel@alsa-project.org
Subject: [PATCH - IOPLUG DRAIN 1/1] jack: Support snd_pcm_drain()
Date: Thu, 22 Mar 2018 14:48:57 +0100 [thread overview]
Message-ID: <1521726537-7651-3-git-send-email-twischer@de.adit-jv.com> (raw)
In-Reply-To: <1521726537-7651-1-git-send-email-twischer@de.adit-jv.com>
From: Timo Wischer <twischer@de.adit-jv.com>
Without this commit the JACK thread will be stopped
before the ALSA buffer was completely forwarded to
the JACK daemon.
Signed-off-by: Timo Wischer <twischer@de.adit-jv.com>
diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
index e3df4d2..5c4d0fc 100644
--- a/jack/pcm_jack.c
+++ b/jack/pcm_jack.c
@@ -85,7 +85,12 @@ static int pcm_poll_unblock_check(snd_pcm_ioplug_t *io)
snd_pcm_jack_t *jack = io->private_data;
avail = snd_pcm_avail_update(io->pcm);
- if (avail < 0 || avail >= jack->min_avail) {
+ /* In draining state poll_fd is used to wait till all pending frames are
+ * played. Therefore it has to be guarantee that a poll event is also
+ * generated if the buffer contains less than min_avail frames.
+ */
+ if (avail < 0 || avail >= jack->min_avail ||
+ io->state == SND_PCM_STATE_DRAINING) {
write(jack->fd, &buf, 1);
return 1;
}
@@ -161,7 +166,8 @@ snd_pcm_jack_process_cb(jack_nframes_t nframes, snd_pcm_ioplug_t *io)
jack->areas[channel].step = jack->sample_bits;
}
- if (io->state == SND_PCM_STATE_RUNNING) {
+ if (io->state == SND_PCM_STATE_RUNNING ||
+ io->state == SND_PCM_STATE_DRAINING) {
snd_pcm_uframes_t hw_ptr = jack->hw_ptr;
const snd_pcm_uframes_t hw_avail = snd_pcm_ioplug_hw_avail(io, hw_ptr,
io->appl_ptr);
@@ -307,6 +313,29 @@ static int snd_pcm_jack_start(snd_pcm_ioplug_t *io)
return 0;
}
+static int snd_pcm_jack_drain(snd_pcm_ioplug_t *io)
+{
+ snd_pcm_jack_t *jack = io->private_data;
+
+ /* Immediately stop on capture device.
+ * snd_pcm_jack_stop() will be automatically called
+ * by snd_pcm_ioplug_drain()
+ */
+ if (io->stream == SND_PCM_STREAM_CAPTURE)
+ return 0;
+
+ if (snd_pcm_ioplug_hw_avail(io, jack->hw_ptr, io->appl_ptr) <= 0) {
+ /* No data pending. Nothing to drain. */
+ return 0;
+ }
+
+ /* start device if not yet done */
+ if (!jack->activated)
+ snd_pcm_jack_start(io);
+
+ return -EAGAIN;
+}
+
static int snd_pcm_jack_stop(snd_pcm_ioplug_t *io)
{
snd_pcm_jack_t *jack = io->private_data;
@@ -333,6 +362,7 @@ static snd_pcm_ioplug_callback_t jack_pcm_callback = {
.stop = snd_pcm_jack_stop,
.pointer = snd_pcm_jack_pointer,
.prepare = snd_pcm_jack_prepare,
+ .drain = snd_pcm_jack_drain,
.poll_revents = snd_pcm_jack_poll_revents,
};
--
2.7.4
next prev parent reply other threads:[~2018-03-22 13:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:48 [PATCH - IOPLUG DRAIN 0/2] twischer
2018-03-22 13:48 ` [PATCH - IOPLUG DRAIN 1/1] ioplug: drain: Wait with pollwhen EAGAIN in blocking mode twischer
2018-03-22 13:48 ` twischer [this message]
2018-03-22 14:28 ` [PATCH - IOPLUG DRAIN 0/2] Takashi Iwai
2018-03-22 14:50 ` Wischer, Timo (ADITG/ESB)
2018-03-22 14:55 ` Takashi Iwai
2018-03-22 15:17 ` Wischer, Timo (ADITG/ESB)
2018-03-22 16:22 ` Takashi Iwai
2018-03-23 7:23 ` Wischer, Timo (ADITG/ESB)
2018-03-23 7:28 ` Takashi Iwai
2018-03-23 7:43 ` Wischer, Timo (ADITG/ESB)
2018-03-23 8:01 ` Takashi Iwai
2018-03-23 8:08 ` Takashi Iwai
2018-03-23 9:03 ` Takashi Iwai
2018-03-28 8:42 ` Wischer, Timo (ADITG/ESB)
2018-03-28 16:09 ` Takashi Iwai
2018-03-29 6:39 ` Wischer, Timo (ADITG/ESB)
2018-03-29 7:25 ` Takashi Iwai
2018-03-29 7:38 ` Wischer, Timo (ADITG/ESB)
2018-03-23 8:21 ` Wischer, Timo (ADITG/ESB)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521726537-7651-3-git-send-email-twischer@de.adit-jv.com \
--to=twischer@de.adit-jv.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).