From: David Woodhouse <dwmw2@infradead.org>
To: Naveen M <naveen.m@intel.com>, Benson Leung <bleung@google.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
harshapriya.n@intel.com, broonie@kernel.org, bleung@chromium.org,
pierre-louis.bossart@intel.com
Subject: Re: [PATCH 2/5] ASoC: Intel: Headset button support in broxton machine driver
Date: Fri, 06 Apr 2018 08:28:35 +0100 [thread overview]
Message-ID: <1522999715.7862.170.camel@infradead.org> (raw)
In-Reply-To: <20180406011548.GA4189@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 600 bytes --]
On Fri, 2018-04-06 at 06:45 +0530, Naveen M wrote:
>
> Thanks for the review and update. Shall correct this in V2.
> Also there are other machines which still use KEY_MEDIA -
> kbl_da7219_max98357a.c, cht_bsw_nau8824.c
> Shall correct these too.
kbl_da7219_max98357a and rk3399_gru_sound also seem to have
KEY_VOICECOMMAND on BTN_3 and volume up/down on 1/2; is that correct?
Until I spotted that, I was going to suggest a generic helper to set
all four, since they should *all* be setting the four events to
KEY_PLAYPAUSE, KEY_VOICECOMMAND, KEY_VOLUMEUP, KEY_VOLUMEDOWN
respectively.
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5213 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-04-06 7:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 4:46 [PATCH 0/5] ASoC: Intel: geminilake: Adds da7219+max98537 machine driver support Naveen Manohar
2018-04-04 4:46 ` [PATCH 1/5] ASoC: Intel: broxton: reduce machine name for bxt_da7219_max98357a Naveen Manohar
2018-06-19 15:24 ` Applied "ASoC: Intel: broxton: reduce machine name for bxt_da7219_max98357a" to the asoc tree Mark Brown
2018-04-04 4:46 ` [PATCH 2/5] ASoC: Intel: Headset button support in broxton machine driver Naveen Manohar
2018-04-06 0:30 ` Benson Leung
2018-04-06 1:15 ` Naveen M
2018-04-06 7:28 ` David Woodhouse [this message]
2018-04-12 15:24 ` Mark Brown
2018-04-04 4:46 ` [PATCH 3/5] ASoC: Intel: Add Geminilake Dialog Maxim machine driver support Naveen Manohar
2018-04-04 15:18 ` Pierre-Louis Bossart
2018-04-04 4:46 ` [PATCH 4/5] ASoC: Intel: glk: Add DAI links for Multi-Playback Naveen Manohar
2018-04-04 4:46 ` [PATCH 5/5] ASoC: Intel: Add Geminilake Dialog+Maxim machine driver entry Naveen Manohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522999715.7862.170.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=broonie@kernel.org \
--cc=harshapriya.n@intel.com \
--cc=naveen.m@intel.com \
--cc=pierre-louis.bossart@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).