alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Sriram Periyasamy <sriramx.periyasamy@intel.com>
To: ALSA ML <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Sriram Periyasamy <sriramx.periyasamy@intel.com>,
	Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>,
	Patches Audio <patches.audio@intel.com>
Subject: [PATCH 3/4] ALSA: hda: Log HDA Hardware related errors
Date: Tue, 15 May 2018 12:10:55 +0530	[thread overview]
Message-ID: <1526366456-20470-4-git-send-email-sriramx.periyasamy@intel.com> (raw)
In-Reply-To: <1526366456-20470-1-git-send-email-sriramx.periyasamy@intel.com>

From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>

Detect the timeout while modifying HDA DMA related Registers
for stream reset and print them to console for user information

Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
Signed-off-by: Sriram Periyasamy <sriramx.periyasamy@intel.com>
---
 sound/hda/hdac_stream.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
index 33c8ced528f6..aa8a2884289f 100644
--- a/sound/hda/hdac_stream.c
+++ b/sound/hda/hdac_stream.c
@@ -144,6 +144,10 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
 		if (val)
 			break;
 	} while (--timeout);
+
+	if (!timeout)
+		dev_err(azx_dev->bus->dev, "timeout on stream reset entry\n");
+
 	val &= ~SD_CTL_STREAM_RESET;
 	snd_hdac_stream_writeb(azx_dev, SD_CTL, val);
 	udelay(3);
@@ -157,6 +161,9 @@ void snd_hdac_stream_reset(struct hdac_stream *azx_dev)
 			break;
 	} while (--timeout);
 
+	if (!timeout)
+		dev_err(azx_dev->bus->dev, "timeout on stream reset exit\n");
+
 	/* reset first position - may not be synced with hw at this time */
 	if (azx_dev->posbuf)
 		*azx_dev->posbuf = 0;
-- 
2.7.4

  parent reply	other threads:[~2018-05-15  6:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  6:40 [PATCH 0/4] ALSA: hda: Bug fixes Sriram Periyasamy
2018-05-15  6:40 ` [PATCH 1/4] ALSA: hda: Make sure DMA is stopped by reading back the RUN bit Sriram Periyasamy
2018-05-15  7:34   ` Takashi Iwai
2018-05-15  6:40 ` [PATCH 2/4] ALSA: hda: Make sure DMA is started " Sriram Periyasamy
2018-05-15  7:36   ` Takashi Iwai
2018-05-15  6:40 ` Sriram Periyasamy [this message]
2018-05-15  7:43   ` [PATCH 3/4] ALSA: hda: Log HDA Hardware related errors Takashi Iwai
2018-05-15  6:40 ` [PATCH 4/4] ALSA: hda: check if stream is stopped in snd_hdac_stream_clear Sriram Periyasamy
2018-05-15  7:41   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1526366456-20470-4-git-send-email-sriramx.periyasamy@intel.com \
    --to=sriramx.periyasamy@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=pardha.saradhi.kesapragada@intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).