alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port
@ 2018-06-19  6:16 mac.chiang
  2018-06-19 14:41 ` Pierre-Louis Bossart
  2018-06-19 15:24 ` Applied "ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port" to the asoc tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: mac.chiang @ 2018-06-19  6:16 UTC (permalink / raw)
  To: alsa-devel
  Cc: naveen.m, mac.chiang, broonie, louiscollard, pierre-louis.bossart

From: Mac Chiang <mac.chiang@intel.com>

platform support fixed constraint hw_prams as Stereo, 48KHz, 16 bits.
This fixed the headset mic recorded noise due to mono capturing
request from some apps. e.g. online Voice Recorder

Signed-off-by: Louis Collard <louiscollard@google.com>
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
---
 sound/soc/intel/boards/kbl_da7219_max98357a.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
index 94294c2..7961f1f 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
@@ -380,6 +380,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
 		.trigger = {
 			SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
 		.dpcm_capture = 1,
+		.ops = &kabylake_da7219_fe_ops,
 	},
 	[KBL_DPCM_AUDIO_DMIC_CP] = {
 		.name = "Kbl Audio DMIC cap",
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port
  2018-06-19  6:16 [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port mac.chiang
@ 2018-06-19 14:41 ` Pierre-Louis Bossart
  2018-06-19 15:24 ` Applied "ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port" to the asoc tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2018-06-19 14:41 UTC (permalink / raw)
  To: mac.chiang, alsa-devel; +Cc: naveen.m, broonie, louiscollard

On 6/19/18 1:16 AM, mac.chiang@intel.com wrote:
> From: Mac Chiang <mac.chiang@intel.com>
> 
> platform support fixed constraint hw_prams as Stereo, 48KHz, 16 bits.
> This fixed the headset mic recorded noise due to mono capturing
> request from some apps. e.g. online Voice Recorder

This change mirrors existing code in bxt_da7219_max98357a.c so

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
> Signed-off-by: Louis Collard <louiscollard@google.com>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> ---
>   sound/soc/intel/boards/kbl_da7219_max98357a.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> index 94294c2..7961f1f 100644
> --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> @@ -380,6 +380,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
>   		.trigger = {
>   			SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
>   		.dpcm_capture = 1,
> +		.ops = &kabylake_da7219_fe_ops,
>   	},
>   	[KBL_DPCM_AUDIO_DMIC_CP] = {
>   		.name = "Kbl Audio DMIC cap",
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port" to the asoc tree
  2018-06-19  6:16 [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port mac.chiang
  2018-06-19 14:41 ` Pierre-Louis Bossart
@ 2018-06-19 15:24 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2018-06-19 15:24 UTC (permalink / raw)
  Cc: alsa-devel, pierre-louis.bossart, mac.chiang, broonie,
	louiscollard, naveen.m

The patch

   ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 5fd46e649ee63259f2197625662477ac67a69e79 Mon Sep 17 00:00:00 2001
From: Mac Chiang <mac.chiang@intel.com>
Date: Tue, 19 Jun 2018 14:16:06 +0800
Subject: [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio
 Capture Port

platform support fixed constraint hw_prams as Stereo, 48KHz, 16 bits.
This fixed the headset mic recorded noise due to mono capturing
request from some apps. e.g. online Voice Recorder

Signed-off-by: Louis Collard <louiscollard@google.com>
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/intel/boards/kbl_da7219_max98357a.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
index 94294c27d1db..7961f1fd18bd 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
@@ -380,6 +380,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
 		.trigger = {
 			SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
 		.dpcm_capture = 1,
+		.ops = &kabylake_da7219_fe_ops,
 	},
 	[KBL_DPCM_AUDIO_DMIC_CP] = {
 		.name = "Kbl Audio DMIC cap",
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-19 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-19  6:16 [PATCH] ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port mac.chiang
2018-06-19 14:41 ` Pierre-Louis Bossart
2018-06-19 15:24 ` Applied "ASoC: Intel: kbl_da7219_max98357a: add fe_ops for kbl Audio Capture Port" to the asoc tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).