From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
alsa-devel@alsa-project.org,
"Nicolò Veronese" <nicveronese@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: add generic simple-amplifier support
Date: Mon, 25 Jun 2018 13:50:59 +0200 [thread overview]
Message-ID: <1529927459.2900.32.camel@baylibre.com> (raw)
In-Reply-To: <20180625114445.GG9413@sirena.org.uk>
On Mon, 2018-06-25 at 12:44 +0100, Mark Brown wrote:
> On Mon, Jun 25, 2018 at 01:31:29PM +0200, Jerome Brunet wrote:
>
> > Same comment as on IRC, you driver looks very similar to the one I posted a
> > while back (sound/soc/codecs/dio2125.c)
> > Could you just add your compatible to the list in the existing driver ?
> > Is there anything I missed which makes them incompatible ?
>
> It's probably a good idea to rename that driver so it's a bit more
> discoverable - you're absolutely right that it's very similar and doing
> basically the same thing but I'd completely forgotten that it existed :/
Agreed , the name is poorly chosen. I did not thought it was a generic need at
the time.
Nicolò, do you want to do the remame ? or would you prefer me to do it ?
Cheers
Jerome
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-06-25 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 11:06 [PATCH 1/2] ASoC: add generic simple-amplifier support Nicolò Veronese
2018-06-25 11:06 ` [PATCH 2/2] ASoC: simple-amplifier: add dt-bindings Nicolò Veronese
2018-06-25 11:21 ` [PATCH 1/2] ASoC: add generic simple-amplifier support Mark Brown
2018-06-25 11:31 ` Jerome Brunet
2018-06-25 11:44 ` Mark Brown
2018-06-25 11:50 ` Jerome Brunet [this message]
2018-06-25 12:07 ` Nicolò Veronese
2018-06-25 12:12 ` Jerome Brunet
2018-06-25 12:28 ` Chen-Yu Tsai
2018-06-25 12:39 ` Mark Brown
2018-06-26 3:20 ` Chen-Yu Tsai
2018-06-26 11:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529927459.2900.32.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=nicveronese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).