* [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
@ 2018-06-28 6:11 mac.chiang
2018-06-28 6:13 ` Benson Leung
2018-06-29 5:46 ` Pierre-Louis Bossart
0 siblings, 2 replies; 8+ messages in thread
From: mac.chiang @ 2018-06-28 6:11 UTC (permalink / raw)
To: alsa-devel; +Cc: mac.chiang, broonie, bleung, pierre-louis.bossart
From: Mac Chiang <mac.chiang@intel.com>
On kbl_rt5663_max98927, commit 38a5882e4292
("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
This key pair mapping to play/pause when playing Youtube
The Android 3.5mm Headset jack specification mentions that BTN_0 should
be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
which has much broader userspace support.
For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
play/pause of videos and audio, but does not handle KEY_MEDIA.
Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec
The same fix is required on Chrome kbl_da7219_max98357a.
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
---
sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
index 7961f1f..edafe23 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
jack = &ctx->kabylake_headset;
- snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
+ snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
2018-06-28 6:11 [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE mac.chiang
@ 2018-06-28 6:13 ` Benson Leung
2018-06-29 5:46 ` Pierre-Louis Bossart
1 sibling, 0 replies; 8+ messages in thread
From: Benson Leung @ 2018-06-28 6:13 UTC (permalink / raw)
To: mac.chiang; +Cc: alsa-devel, broonie, bleung, pierre-louis.bossart, bleung
[-- Attachment #1.1: Type: text/plain, Size: 1180 bytes --]
Hi Mac,
On Thu, Jun 28, 2018 at 02:11:07PM +0800, mac.chiang@intel.com wrote:
> From: Mac Chiang <mac.chiang@intel.com>
>
> On kbl_rt5663_max98927, commit 38a5882e4292
> ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
> This key pair mapping to play/pause when playing Youtube
>
> The Android 3.5mm Headset jack specification mentions that BTN_0 should
> be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
> which has much broader userspace support.
>
> For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
> play/pause of videos and audio, but does not handle KEY_MEDIA.
>
> Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
> new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
> https://source.android.com/devices/accessories/headset/usb-headset-spec
>
> The same fix is required on Chrome kbl_da7219_max98357a.
>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
2018-06-28 6:11 [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE mac.chiang
2018-06-28 6:13 ` Benson Leung
@ 2018-06-29 5:46 ` Pierre-Louis Bossart
2018-06-29 5:59 ` Naveen M
1 sibling, 1 reply; 8+ messages in thread
From: Pierre-Louis Bossart @ 2018-06-29 5:46 UTC (permalink / raw)
To: mac.chiang, alsa-devel; +Cc: M, Naveen, broonie, bleung
On 6/27/18 11:11 PM, mac.chiang@intel.com wrote:
> From: Mac Chiang <mac.chiang@intel.com>
>
> On kbl_rt5663_max98927, commit 38a5882e4292
> ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
> This key pair mapping to play/pause when playing Youtube
>
> The Android 3.5mm Headset jack specification mentions that BTN_0 should
> be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
> which has much broader userspace support.
>
> For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
> play/pause of videos and audio, but does not handle KEY_MEDIA.
>
> Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
> new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
> https://source.android.com/devices/accessories/headset/usb-headset-spec
>
> The same fix is required on Chrome kbl_da7219_max98357a.
>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
this is aligned with a recent patch for the same headset for an AMD
platform. We'd need the same fix for the bxt_da7219 machine driver btw.
Naveen, is this something you can look into? Thanks!
> ---
> sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> index 7961f1f..edafe23 100644
> --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> @@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
>
> jack = &ctx->kabylake_headset;
>
> - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
2018-06-29 5:46 ` Pierre-Louis Bossart
@ 2018-06-29 5:59 ` Naveen M
2018-06-29 21:31 ` Pierre-Louis Bossart
0 siblings, 1 reply; 8+ messages in thread
From: Naveen M @ 2018-06-29 5:59 UTC (permalink / raw)
To: Pierre-Louis Bossart; +Cc: mac.chiang, broonie, bleung, alsa-devel
On Thu, Jun 28, 2018 at 10:46:58PM -0700, Pierre-Louis Bossart wrote:
> On 6/27/18 11:11 PM, mac.chiang@intel.com wrote:
> >From: Mac Chiang <mac.chiang@intel.com>
> >
> >On kbl_rt5663_max98927, commit 38a5882e4292
> > ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
> > This key pair mapping to play/pause when playing Youtube
> >
> >The Android 3.5mm Headset jack specification mentions that BTN_0 should
> >be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
> >which has much broader userspace support.
> >
> >For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
> >play/pause of videos and audio, but does not handle KEY_MEDIA.
> >
> >Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
> >new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
> >https://source.android.com/devices/accessories/headset/usb-headset-spec
> >
> >The same fix is required on Chrome kbl_da7219_max98357a.
> >
> >Signed-off-by: Mac Chiang <mac.chiang@intel.com>
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> this is aligned with a recent patch for the same headset for an AMD
> platform. We'd need the same fix for the bxt_da7219 machine driver btw.
> Naveen, is this something you can look into? Thanks!
>
>
Agreed Pierre, earlier I have submitted a patch on this for bxt_da7219 -
https://patchwork.kernel.org/patch/10335295/
Also I have updated the same for recently ack'd glk_rt5682_max machine.
> >---
> > sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> >index 7961f1f..edafe23 100644
> >--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> >+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> >@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
> > jack = &ctx->kabylake_headset;
> >- snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
> >+ snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
> > snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
> > snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
> > snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
> >
>
--
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
2018-06-29 5:59 ` Naveen M
@ 2018-06-29 21:31 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2018-06-29 21:31 UTC (permalink / raw)
To: alsa-devel-bounces; +Cc: mac.chiang, broonie, bleung, alsa-devel
On 6/29/18 12:59 AM, alsa-devel-bounces@alsa-project.org wrote:
> On Thu, Jun 28, 2018 at 10:46:58PM -0700, Pierre-Louis Bossart wrote:
>> On 6/27/18 11:11 PM, mac.chiang@intel.com wrote:
>>> From: Mac Chiang <mac.chiang@intel.com>
>>>
>>> On kbl_rt5663_max98927, commit 38a5882e4292
>>> ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
>>> This key pair mapping to play/pause when playing Youtube
>>>
>>> The Android 3.5mm Headset jack specification mentions that BTN_0 should
>>> be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
>>> which has much broader userspace support.
>>>
>>> For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
>>> play/pause of videos and audio, but does not handle KEY_MEDIA.
>>>
>>> Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
>>> new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
>>> https://source.android.com/devices/accessories/headset/usb-headset-spec
>>>
>>> The same fix is required on Chrome kbl_da7219_max98357a.
>>>
>>> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
>>
>> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> this is aligned with a recent patch for the same headset for an AMD
>> platform. We'd need the same fix for the bxt_da7219 machine driver btw.
>> Naveen, is this something you can look into? Thanks!
>>
>>
> Agreed Pierre, earlier I have submitted a patch on this for bxt_da7219 -
> https://patchwork.kernel.org/patch/10335295/
> Also I have updated the same for recently ack'd glk_rt5682_max machine.
Right, but neither of those patches were merged? I may be mistaken but
this code wasn't in Mark's tree when I looked yesterday.
>>> ---
>>> sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
>>> index 7961f1f..edafe23 100644
>>> --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
>>> +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
>>> @@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
>>> jack = &ctx->kabylake_headset;
>>> - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
>>> + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
>>> snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
>>> snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
>>> snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
>>>
>>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
@ 2019-05-02 6:12 mac.chiang@intel.com--cc=pierre-louis.bossart
2019-05-02 16:14 ` Pierre-Louis Bossart
0 siblings, 1 reply; 8+ messages in thread
From: mac.chiang@intel.com--cc=pierre-louis.bossart @ 2019-05-02 6:12 UTC (permalink / raw)
To: alsa-devel; +Cc: mac.chiang, broonie, chintan.m.patel
From: Mac Chiang <mac.chiang@intel.com>
On kbl_rt5663_max98927, commit 38a5882e4292
("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
This key pair mapping to play/pause when playing Youtube
The Android 3.5mm Headset jack specification mentions that BTN_0 should
be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
which has much broader userspace support.
For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
play/pause of videos and audio, but does not handle KEY_MEDIA.
Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec
The same fix is required on Chrome kbl_da7219_max98357a.
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
index 38f6ab7..07491a0 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
jack = &ctx->kabylake_headset;
- snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
+ snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
2019-05-02 6:12 mac.chiang@intel.com--cc=pierre-louis.bossart
@ 2019-05-02 16:14 ` Pierre-Louis Bossart
0 siblings, 0 replies; 8+ messages in thread
From: Pierre-Louis Bossart @ 2019-05-02 16:14 UTC (permalink / raw)
To: "mac.chiang, alsa-devel; +Cc: mac.chiang, broonie, chintan.m.patel
> From: Mac Chiang <mac.chiang@intel.com>
>
> On kbl_rt5663_max98927, commit 38a5882e4292
> ("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
> This key pair mapping to play/pause when playing Youtube
>
> The Android 3.5mm Headset jack specification mentions that BTN_0 should
> be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
> which has much broader userspace support.
>
> For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
> play/pause of videos and audio, but does not handle KEY_MEDIA.
>
> Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
> new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
> https://source.android.com/devices/accessories/headset/usb-headset-spec
>
> The same fix is required on Chrome kbl_da7219_max98357a.
>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> Reviewed-by: Benson Leung <bleung@chromium.org>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mark, to be clear it's a resend of a patch initially submitted in 2018,
see https://patchwork.kernel.org/patch/10493135/
> ---
> sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> index 38f6ab7..07491a0 100644
> --- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
> +++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
> @@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
>
> jack = &ctx->kabylake_headset;
>
> - snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
> + snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
> snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
@ 2019-05-02 6:16 mac.chiang
0 siblings, 0 replies; 8+ messages in thread
From: mac.chiang @ 2019-05-02 6:16 UTC (permalink / raw)
To: alsa-devel; +Cc: mac.chiang, broonie, chintan.m.patel, pierre-louis.bossart
From: Mac Chiang <mac.chiang@intel.com>
On kbl_rt5663_max98927, commit 38a5882e4292
("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE")
This key pair mapping to play/pause when playing Youtube
The Android 3.5mm Headset jack specification mentions that BTN_0 should
be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE,
which has much broader userspace support.
For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle
play/pause of videos and audio, but does not handle KEY_MEDIA.
Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the
new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec
The same fix is required on Chrome kbl_da7219_max98357a.
Signed-off-by: Mac Chiang <mac.chiang@intel.com>
Reviewed-by: Benson Leung <bleung@chromium.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/kbl_da7219_max98357a.c b/sound/soc/intel/boards/kbl_da7219_max98357a.c
index 38f6ab7..07491a0 100644
--- a/sound/soc/intel/boards/kbl_da7219_max98357a.c
+++ b/sound/soc/intel/boards/kbl_da7219_max98357a.c
@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd)
jack = &ctx->kabylake_headset;
- snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_MEDIA);
+ snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOLUMEUP);
snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN);
snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOICECOMMAND);
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-02 16:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-28 6:11 [PATCH] ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE mac.chiang
2018-06-28 6:13 ` Benson Leung
2018-06-29 5:46 ` Pierre-Louis Bossart
2018-06-29 5:59 ` Naveen M
2018-06-29 21:31 ` Pierre-Louis Bossart
-- strict thread matches above, loose matches on Subject: below --
2019-05-02 6:12 mac.chiang@intel.com--cc=pierre-louis.bossart
2019-05-02 16:14 ` Pierre-Louis Bossart
2019-05-02 6:16 mac.chiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).