From: Shreyas NC <shreyas.nc@intel.com>
To: alsa-devel@alsa-project.org
Cc: patches.audio@intel.com, gregkh@linuxfoundation.org,
pierre-louis.bossart@linux.intel.com, vkoul@kernel.org,
Shreyas NC <shreyas.nc@intel.com>,
sanyog.r.kale@intel.com
Subject: [PATCH v8 03/10] soundwire: Fix acquiring bus lock twice during master release
Date: Fri, 27 Jul 2018 14:44:10 +0530 [thread overview]
Message-ID: <1532682857-604-4-git-send-email-shreyas.nc@intel.com> (raw)
In-Reply-To: <1532682857-604-1-git-send-email-shreyas.nc@intel.com>
From: Sanyog Kale <sanyog.r.kale@intel.com>
As part of sdw_stream_remove_master(), sdw_stream_remove_slave() is called
which results in bus lock being acquired twice.
So, fix it by performing specific Slave remove operations in
sdw_release_master_stream() instead of calling sdw_stream_remove_slave().
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Sanyog Kale <sanyog.r.kale@intel.com>
Signed-off-by: Shreyas NC <shreyas.nc@intel.com>
---
drivers/soundwire/stream.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index eaaa180..28d4147 100644
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -899,9 +899,10 @@ static void sdw_release_master_stream(struct sdw_stream_runtime *stream)
struct sdw_master_runtime *m_rt = stream->m_rt;
struct sdw_slave_runtime *s_rt, *_s_rt;
- list_for_each_entry_safe(s_rt, _s_rt,
- &m_rt->slave_rt_list, m_rt_node)
- sdw_stream_remove_slave(s_rt->slave, stream);
+ list_for_each_entry_safe(s_rt, _s_rt, &m_rt->slave_rt_list, m_rt_node) {
+ sdw_slave_port_release(s_rt->slave->bus, s_rt->slave, stream);
+ sdw_release_slave_stream(s_rt->slave, stream);
+ }
list_del(&m_rt->bus_node);
}
--
2.7.4
next prev parent reply other threads:[~2018-07-27 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 9:14 [PATCH v8 00/10] soundwire: Add multi link support Shreyas NC
2018-07-27 9:14 ` [PATCH v8 01/10] soundwire: Fix duplicate stream state assignment Shreyas NC
2018-07-27 9:14 ` [PATCH v8 02/10] soundwire: Fix incorrect exit after configuring stream Shreyas NC
2018-07-27 9:14 ` Shreyas NC [this message]
2018-07-27 9:14 ` [PATCH v8 04/10] Documentation: soundwire: Add documentation for multi link Shreyas NC
2018-07-27 9:14 ` [PATCH v8 05/10] soundwire: Initialize completion for defer messages Shreyas NC
2018-07-27 9:14 ` [PATCH v8 06/10] soundwire: Add support to lock across bus instances Shreyas NC
2018-07-27 9:14 ` [PATCH v8 07/10] soundwire: Handle multiple master instances in a stream Shreyas NC
2018-07-27 9:14 ` [PATCH v8 08/10] soundwire: keep track of Masters " Shreyas NC
2018-07-27 9:14 ` [PATCH v8 09/10] soundwire: Add support for multi link bank switch Shreyas NC
2018-07-27 9:14 ` [PATCH v8 10/10] soundwire: intel: Add pre/post bank switch ops Shreyas NC
2018-07-27 15:12 ` [PATCH v8 00/10] soundwire: Add multi link support Pierre-Louis Bossart
2018-08-07 6:51 ` Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532682857-604-4-git-send-email-shreyas.nc@intel.com \
--to=shreyas.nc@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=patches.audio@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).