Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

Viorel Suman
2019-01-03T19:21:48Z

> -----Original Message-----
> From: Rob Herring [mailto:robh+dt@kernel.org]
> Sent: Thursday, January 3, 2019 8:26 PM
> To: Viorel Suman <viorel.suman@nxp.com>
> Cc: nicoleotsuka@gmail.com; dl-linux-imx <linux-imx@nxp.com>; linux-
> kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; timur@kernel.org;
> devicetree@vger.kernel.org; Xiubo.Lee@gmail.com; Fabio Estevam
> <fabio.estevam@nxp.com>; broonie@kernel.org; mark.rutland@arm.com;
> tiwai@suse.com; lgirdwood@gmail.com; Daniel Baluta
> <daniel.baluta@nxp.com>; perex@perex.cz; alsa-devel@alsa-project.org
> Subject: Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver
>
> On Thu, Jan 3, 2019 at 9:59 AM Viorel Suman <viorel.suman@nxp.com> wrote:
> >
> > Hi Nicolin,
> >
> > Thank you for your feedback, same here - just back from vacation.
> >
> > On Jo, 2018-12-27 at 01:24 +0800, Nicolin Chen wrote:
> > > Hi Viorel,
> > >
> > > Sorry for the late response, having been on a long vacation.
> > >
> > > The code looks pretty clean. Just some small concerns/questions
> > > below.
> > >
> > > On Wed, Dec 19, 2018 at 12:30 AM Viorel Suman <viorel.suman@nxp.com>
> > > wrote:
> > > >
> > > >
> > > > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs.
> > > > The Audio Mixer is a on-chip functional module that allows mixing
> > > > of two audio streams into a single audio stream.
> > > >
> > > > Audio Mixer datasheet is available here:
> > > > https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf
> > > >
> > > > Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
> > > > ---
> > > > .../devicetree/bindings/sound/fsl,amix.txt | 45 ++
> > > > sound/soc/fsl/Kconfig | 7 +
> > > > sound/soc/fsl/Makefile | 3 +
> > > > sound/soc/fsl/fsl_amix.c | 554
> > > > +++++++++++++++++++++
> > > > sound/soc/fsl/fsl_amix.h | 101 ++++
> > > I aimn't against the naming here, but it seems to be AUDMIX in RM?
> > >
> > > Would it be better to align with that? It's your decision though.
> >
> > To me "AUDMIX" sounds more like some RTL high level integration
> > module, I would prefer to keep it as it is if there is no strong
> > reason to rename it.
>
> At least for compatible string names, matching what's in the RM or RTL is more
> appropriate. Where does "AMIX" come from?
>
> Rob

There are places in RM where Audio Mixer is referred as "AMIX":
1. Page 33, "Table 2-6. Audio DMA Memory Map"
2. Page 259, "LPCG_AMIX_REGS"
3. Page 6816, "Table 16-1. ADMA Subsystem Modules"

/Viorel