* [PATCH] Headset microphone support for System76 darp5
@ 2019-01-29 19:52 Jeremy Soller
2019-01-30 17:34 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Soller @ 2019-01-29 19:52 UTC (permalink / raw)
To: alsa-devel
Headset microphone support for System76 darp5
Signed-off-by: Jeremy Soller <jeremy@system76.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4f472157ebd..15fedb0eeae1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5591,6 +5591,7 @@ enum {
ALC294_FIXUP_ASUS_HEADSET_MIC,
ALC294_FIXUP_ASUS_SPK,
ALC225_FIXUP_HEADSET_JACK,
+ ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE,
};
static const struct hda_fixup alc269_fixups[] = {
@@ -6537,6 +6538,15 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_headset_jack,
},
+ [ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x1a, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
+ },
};
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -6606,6 +6616,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY),
+ SND_PCI_QUIRK(0x1558, 0x1325, "System76", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
/* ALC282 */
SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Headset microphone support for System76 darp5
2019-01-29 19:52 [PATCH] Headset microphone support for System76 darp5 Jeremy Soller
@ 2019-01-30 17:34 ` Takashi Iwai
2019-01-30 23:07 ` Jeremy Soller
0 siblings, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2019-01-30 17:34 UTC (permalink / raw)
To: Jeremy Soller; +Cc: alsa-devel
On Tue, 29 Jan 2019 20:52:01 +0100,
Jeremy Soller wrote:
>
> Headset microphone support for System76 darp5
The changes look mostly OK, but could you give a bit more details?
> @@ -6606,6 +6616,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY),
> + SND_PCI_QUIRK(0x1558, 0x1325, "System76", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> /* ALC282 */
> SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
We keep the list in the ID number order, so please put at the
appropriate place.
thanks,
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Headset microphone support for System76 darp5
2019-01-30 17:34 ` Takashi Iwai
@ 2019-01-30 23:07 ` Jeremy Soller
2019-01-30 23:12 ` Jeremy Soller
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Soller @ 2019-01-30 23:07 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
That is good to know. I will resend the patch soon.
--
Jeremy Soller
System76, Inc.
Engineering Manager
jeremy@system76.com
On Wed, Jan 30, 2019, at 10:34 AM, Takashi Iwai wrote:
> On Tue, 29 Jan 2019 20:52:01 +0100,
> Jeremy Soller wrote:
> >
> > Headset microphone support for System76 darp5
>
> The changes look mostly OK, but could you give a bit more details?
>
> > @@ -6606,6 +6616,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x18e6, "HP", ALC269_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x218b, "HP", ALC269_FIXUP_LIMIT_INT_MIC_BOOST_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x225f, "HP", ALC280_FIXUP_HP_GPIO2_MIC_HOTKEY),
> > + SND_PCI_QUIRK(0x1558, 0x1325, "System76", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
> > /* ALC282 */
> > SND_PCI_QUIRK(0x103c, 0x21f9, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> > SND_PCI_QUIRK(0x103c, 0x2210, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1),
>
> We keep the list in the ID number order, so please put at the
> appropriate place.
>
>
> thanks,
>
> Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Headset microphone support for System76 darp5
2019-01-30 23:07 ` Jeremy Soller
@ 2019-01-30 23:12 ` Jeremy Soller
2019-01-31 11:35 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Soller @ 2019-01-30 23:12 UTC (permalink / raw)
To: Takashi Iwai; +Cc: alsa-devel
On the System76 Darter Pro (darp5), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is similar to the MIC_NO_PRESENCE fixups for some Dell laptops, except we have a separate microphone jack that is already configured correctly.
Signed-off-by: Jeremy Soller <jeremy@system76.com>
---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b4f472157ebd..eae02e0469fc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5591,6 +5591,7 @@ enum {
ALC294_FIXUP_ASUS_HEADSET_MIC,
ALC294_FIXUP_ASUS_SPK,
ALC225_FIXUP_HEADSET_JACK,
+ ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE,
};
static const struct hda_fixup alc269_fixups[] = {
@@ -6537,6 +6538,15 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc_fixup_headset_jack,
},
+ [ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x1a, 0x01a1913c }, /* use as headset mic, without its own jack detect */
+ { }
+ },
+ .chained = true,
+ .chain_id = ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC
+ },
};
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -6715,6 +6725,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1458, 0xfa53, "Gigabyte BXBT-2807", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1462, 0xb120, "MSI Cubi MS-B120", ALC283_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1462, 0xb171, "Cubi N 8GL (MS-B171)", ALC283_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1558, 0x1325, "System76 Darter Pro (darp5)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Headset microphone support for System76 darp5
2019-01-30 23:12 ` Jeremy Soller
@ 2019-01-31 11:35 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2019-01-31 11:35 UTC (permalink / raw)
To: Jeremy Soller; +Cc: alsa-devel
On Thu, 31 Jan 2019 00:12:31 +0100,
Jeremy Soller wrote:
>
> On the System76 Darter Pro (darp5), there is a headset microphone input attached to 0x1a that does not have a jack detect. In order to get it working, the pin configuration needs to be set correctly, and the ALC269_FIXUP_HEADSET_MODE_NO_HP_MIC fixup needs to be applied. This is similar to the MIC_NO_PRESENCE fixups for some Dell laptops, except we have a separate microphone jack that is already configured correctly.
>
> Signed-off-by: Jeremy Soller <jeremy@system76.com>
Applied now, thanks.
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-31 11:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 19:52 [PATCH] Headset microphone support for System76 darp5 Jeremy Soller
2019-01-30 17:34 ` Takashi Iwai
2019-01-30 23:07 ` Jeremy Soller
2019-01-30 23:12 ` Jeremy Soller
2019-01-31 11:35 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).