From: Olivier Moysan <olivier.moysan@st.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-kernel@vger.kernel.org, olivier.moysan@st.com,
arnaud.pouliquen@st.com, benjamin.gaignard@st.com
Subject: [PATCH 7/7] ASoC: stm32: i2s: skip useless write in slave mode
Date: Tue, 26 Feb 2019 14:51:10 +0100 [thread overview]
Message-ID: <1551189070-15469-8-git-send-email-olivier.moysan@st.com> (raw)
In-Reply-To: <1551189070-15469-1-git-send-email-olivier.moysan@st.com>
Dummy write in capture master mode is used to gate
bus clocks. This write is useless in slave mode
as the clocks are not managed by slave.
Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
---
sound/soc/stm/stm32_i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c
index 42ce87a35104..47c334de6b09 100644
--- a/sound/soc/stm/stm32_i2s.c
+++ b/sound/soc/stm/stm32_i2s.c
@@ -623,8 +623,8 @@ static int stm32_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
} else {
ier = I2S_IER_OVRIE;
- if (i2s->refcount == 1)
- /* dummy write to trigger capture */
+ if (STM32_I2S_IS_MASTER(i2s) && i2s->refcount == 1)
+ /* dummy write to gate bus clocks */
regmap_write(i2s->regmap,
STM32_I2S_TXDR_REG, 0);
}
--
2.7.4
next prev parent reply other threads:[~2019-02-26 13:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 13:51 [PATCH 0/7] ASoC: stm32: i2s: miscellaneous fixes Olivier Moysan
2019-02-26 13:51 ` [PATCH 1/7] ASoC: stm32: i2s: fix IRQ clearing Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: fix IRQ clearing" to the asoc tree Mark Brown
2019-02-26 13:51 ` [PATCH 2/7] ASoC: stm32: i2s: fix 16 bit format support Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: fix 16 bit format support" to the asoc tree Mark Brown
2019-02-26 13:51 ` [PATCH 3/7] ASoC: stm32: i2s: fix stream count management Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: fix stream count management" to the asoc tree Mark Brown
2019-02-26 13:51 ` [PATCH 4/7] ASoC: stm32: i2s: fix dma configuration Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: fix dma configuration" to the asoc tree Mark Brown
2019-02-26 13:51 ` [PATCH 5/7] ASoC: stm32: i2s: remove useless callback Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: remove useless callback" to the asoc tree Mark Brown
2019-02-26 13:51 ` [PATCH 6/7] ASoC: stm32: i2s: fix race condition in irq handler Olivier Moysan
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: fix race condition in irq handler" to the asoc tree Mark Brown
2019-02-26 13:51 ` Olivier Moysan [this message]
2019-02-26 16:22 ` Applied "ASoC: stm32: i2s: skip useless write in slave mode" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551189070-15469-8-git-send-email-olivier.moysan@st.com \
--to=olivier.moysan@st.com \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).