From: Piotr Maziarz <piotrx.maziarz@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: cezary.rojewski@intel.com, amadeuszx.slawinski@intel.com
Subject: [PATCH v3 00/10] topology: decode: Various fixes
Date: Tue, 14 Jul 2020 13:25:01 +0200 [thread overview]
Message-ID: <1594725911-14308-1-git-send-email-piotrx.maziarz@linux.intel.com> (raw)
This series fixes various problems with topology decoding mechanism.
Some of the problems were critical like improper memory management or
infinite loops that were causing undefined behaviour or program crashes,
while other resulted in losing some data during conversion.
Bugs found while testing with Intel SST topologies.
Changelog:
v2:
-Divide into more patches, critical fixes are in separate patches now
-More specific descriptions
-Fix a typo UML to UCM
-Add error reporting in topology: decode: fix channel map memory
allocation
-Remove goto again in topology: Make buffer for saving dynamic size
for better readability
v3:
-No functional changes
-Changed UCM to more descriptive standard ALSA configuration files
-removed Gerrit's Change-Id
-Added missing signed-offs
Piotr Maziarz (10):
topology: decode: Fix channel map memory allocation
topology: decode: Fix infinite loop in decoding enum control
topology: decode: Remove decoding values for enum control
topology: decode: Add enum control texts as separate element
topology: decode: Fix printing texts section
topology: decode: Change declaration of enum decoding function
topology: decode: Fix decoding PCM formats and rates
topology: decode: Print sig_bits field in PCM capabilities section
topology: decode: Add DAI name printing
topology: Make buffer for saving dynamic size
src/topology/ctl.c | 51 ++++++++++++++++++++++-------------------------
src/topology/dapm.c | 3 +--
src/topology/pcm.c | 11 +++++++---
src/topology/save.c | 34 ++++++++++++++++++++++++++-----
src/topology/text.c | 2 +-
src/topology/tplg_local.h | 2 +-
6 files changed, 64 insertions(+), 39 deletions(-)
--
2.7.4
next reply other threads:[~2020-07-14 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 11:25 Piotr Maziarz [this message]
2020-07-14 11:25 ` [PATCH v3 01/10] topology: decode: Fix channel map memory allocation Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 02/10] topology: decode: Fix infinite loop in decoding enum control Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 03/10] topology: decode: Remove decoding values for " Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 04/10] topology: decode: Add enum control texts as separate element Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 05/10] topology: decode: Fix printing texts section Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 06/10] topology: decode: Change declaration of enum decoding function Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 07/10] topology: decode: Fix decoding PCM formats and rates Piotr Maziarz
2020-07-14 15:40 ` Pierre-Louis Bossart
2020-07-15 9:37 ` Piotr Maziarz
2020-07-15 14:37 ` Pierre-Louis Bossart
2020-07-15 16:18 ` Cezary Rojewski
2020-07-14 11:25 ` [PATCH v3 08/10] topology: decode: Print sig_bits field in PCM capabilities section Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 09/10] topology: decode: Add DAI name printing Piotr Maziarz
2020-07-14 11:25 ` [PATCH v3 10/10] topology: Make buffer for saving dynamic size Piotr Maziarz
2020-07-15 14:47 ` [PATCH v3 00/10] topology: decode: Various fixes Pierre-Louis Bossart
2020-07-15 16:20 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594725911-14308-1-git-send-email-piotrx.maziarz@linux.intel.com \
--to=piotrx.maziarz@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@intel.com \
--cc=cezary.rojewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).